Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] add more debug log #3720

Merged
merged 2 commits into from
May 23, 2024
Merged

[improve] add more debug log #3720

merged 2 commits into from
May 23, 2024

Conversation

Mrart
Copy link

@Mrart Mrart commented May 22, 2024

Contribution Checklist

What changes were proposed in this pull request

Issue Number: close #xxx

Brief change log

add more debug log

Verifying this change

This change is already covered by existing tests, such as (please describe tests).
no

This change added tests and can be verified as follows:
[improve] add more debug log

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (no)

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caicancai
Copy link
Member

@wolfboys I don’t know why the code now mentions the release branch, 2.1.5 instead of the dev branch. I don’t know if this is the right decision, but in my opinion it is unreasonable.
I remember I expressed my concern a long time ago that when there are more and more branches and the differences between them and the dev branch become larger and larger, it will be difficult to maintain.

@wolfboys
Copy link
Member

@wolfboys I don’t know why the code now mentions the release branch, 2.1.5 instead of the dev branch. I don’t know if this is the right decision, but in my opinion it is unreasonable. I remember I expressed my concern a long time ago that when there are more and more branches and the differences between them and the dev branch become larger and larger, it will be difficult to maintain.

2.1.5 only accepts bug fixes and improvements, and does not introduce new features. Currently, the official release version of StreamPark is still the 2.1. x. Therefore, before the official release of version 2.2, bugs and PRs reported by users will be accepted. Updating multiple branches is normal development work. Many projects maintain multiple branches at the same time, such as Apache Flink..

@wolfboys wolfboys merged commit b739eb0 into apache:dev-2.1.5 May 23, 2024
8 checks passed
@caicancai
Copy link
Member

@Mrart Can you submit another pr to dev?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants