Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[catalog] Introduce catalog managed #3936

Merged
merged 7 commits into from
Aug 7, 2024
Merged

[catalog] Introduce catalog managed #3936

merged 7 commits into from
Aug 7, 2024

Conversation

Mrart
Copy link
Contributor

@Mrart Mrart commented Aug 1, 2024

What changes were proposed in this pull request

Issue Number: close #3935

Brief change log

introduce catalogn managed

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.
no
This change is already covered by existing tests, such as (please describe tests).

no

This change added tests and can be verified as follows:

  • *Added CatalogServiceTest to verify the change.
  • Manually verified the change by testing locally. -->

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (no)

@Mrart Mrart force-pushed the 3935 branch 2 times, most recently from 9463c55 to 0bfa112 Compare August 1, 2024 14:16
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that this was a subtask of SPIP, but I didn't find the design detail or the purpose of the code in the PR and related issues. Please fill them in first. @Mrart

@Mrart
Copy link
Contributor Author

Mrart commented Aug 6, 2024

I noticed that this was a subtask of SPIP, but I didn't find the design detail or the purpose of the code in the PR and related issues. Please fill them in first. @Mrart
In this link
#3912

@Mrart Mrart force-pushed the 3935 branch 2 times, most recently from dfa2275 to f1db0da Compare August 6, 2024 06:02
@Mrart Mrart requested a review from SbloodyS August 6, 2024 06:22
@Mrart Mrart force-pushed the 3935 branch 3 times, most recently from 6a92498 to 350a638 Compare August 6, 2024 07:43
Copy link

sonarcloud bot commented Aug 7, 2024

@Mrart Mrart requested a review from wolfboys August 7, 2024 05:37
Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit 33c64e8 into apache:dev Aug 7, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Catalog] Introduce catalog crud.
3 participants