Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore view save modal spec #3110

Merged
merged 20 commits into from
Aug 11, 2017
Merged

Explore view save modal spec #3110

merged 20 commits into from
Aug 11, 2017

Conversation

graceguo-supercat
Copy link

add unit tests for Explore view saveModal. These tests are based on sliced reducer (saveModalReducer).

@coveralls
Copy link

coveralls commented Aug 7, 2017 •
edited

Coverage Status

Coverage remained the same at 69.311% when pulling b6da30f on graceguo-supercat:gg-ExploreViewSaveModalSpec into f68189b on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.311% when pulling b6da30f on graceguo-supercat:gg-ExploreViewSaveModalSpec into f68189b on apache:master.

@mistercrunch
Copy link
Member

LGTM, want me to merge it since you don't have write access [yet]?

mistercrunch and others added 13 commits August 10, 2017 14:58
@mistercrunch
[bugfix] wrong 'Cant have overlap between Series and Breakdowns' (apa…
bfbee82 
…che#3254)
@mistercrunch
[explore] make edit datasource a basic link (apache#3244)
367a4da
import logging (apache#3264)
ab19f1f
@mistercrunch
Relying on FAB for font-awesome.min.css (apache#3261)
de1ab25
@Fokko
Explicitly add Flask as dependancy (apache#3252)
c2f3c48
@mistercrunch
Modernize SQLA pessimistic handling (apache#3256)
479b319 
Looks like SQLAlchemy has redefined the best practice around
pessimistic connection handling.
@eeve
Improve the chart type of Visualize in sqllab (apache#3241)
976ed1c 
* Improve the chart type of Visualize in sqllab & Add some css & Fix the link address in the navbar

* add vizTypes filter
@mistercrunch
[webpack] break CSS and JS files while webpackin' (apache#3262)
bff35d9 
* [webpack] break CSS and JS files while webpackin'

* cleaning up some templates

* Fix pylint issue
@Fokko
Set default ports Druid (apache#3266)
3266749 
For Druid set the default port for the broker and coordinator.
@mistercrunch
[bugfix] preserve order in groupby (apache#3268)
5877883 
Recently in
apache@4c3313b
I introduced an issue where the order of groupby fields might change.

This addresses this issue and will preserve ordering.
@saguziel
Use sane Celery defaults to prevent tasks from being delayed (apache#…
3d78940 
…3267)
[explore] Split large reducer logic in ExploreViewContainer (apache#3088
707ee37 
)

* split reducer logic for ExploreViewContainer

* fix saveModal component and unit tests

* revert changes in SaveModal_spec.
will make another commit just to improve test coverage for SaveModal component.

* remove comment-out code

* fix merge confilicts
Merge remote-tracking branch 'upstream/master' into gg-ExploreViewSav…
8fa7db8 
…eModalSpec
@coveralls
Copy link

coveralls commented Aug 10, 2017 •
edited

Coverage Status

Coverage remained the same at 69.315% when pulling 8fa7db8 on graceguo-supercat:gg-ExploreViewSaveModalSpec into b3107bb on apache:master.

@mistercrunch mistercrunch merged commit b68084b into apache:master Aug 11, 2017
@graceguo-supercat graceguo-supercat deleted the gg-ExploreViewSaveModalSpec branch August 15, 2017 22:27
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1 labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@graceguo-supercat @coveralls @mistercrunch @Fokko @eeve @saguziel