-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore view save modal spec #3110
Merged
mistercrunch
merged 20 commits into
apache:master
from
graceguo-supercat:gg-ExploreViewSaveModalSpec
Aug 11, 2017
Merged
Explore view save modal spec #3110
mistercrunch
merged 20 commits into
apache:master
from
graceguo-supercat:gg-ExploreViewSaveModalSpec
Aug 11, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will make another commit just to improve test coverage for SaveModal component.
- SaveModal component - URLShortLinkButton
…c' into gg-ExploreViewSaveModalSpec
1 similar comment
LGTM, want me to merge it since you don't have write access [yet]? |
Looks like SQLAlchemy has redefined the best practice around pessimistic connection handling.
* Improve the chart type of Visualize in sqllab & Add some css & Fix the link address in the navbar * add vizTypes filter
* [webpack] break CSS and JS files while webpackin' * cleaning up some templates * Fix pylint issue
For Druid set the default port for the broker and coordinator.
Recently in apache@4c3313b I introduced an issue where the order of groupby fields might change. This addresses this issue and will preserve ordering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add unit tests for Explore view saveModal. These tests are based on sliced reducer (saveModalReducer).