Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hive] improve error messages #3305

Merged
merged 2 commits into from
Aug 17, 2017
Merged

[hive] improve error messages #3305

merged 2 commits into from
Aug 17, 2017

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Aug 16, 2017 •
edited

before/after
screen shot 2017-08-16 at 10 15 28 am
screen shot 2017-08-16 at 10 14 35 am

closes #3303

@coveralls
Copy link

coveralls commented Aug 16, 2017 •
edited

Coverage Status

Coverage decreased (-0.06%) to 69.361% when pulling 628bc33 on mistercrunch:hive_err_msg into 232a5c3 on apache:master.

xrmx
xrmx reviewed Aug 16, 2017
View reviewed changes
superset/db_engine_specs.py
@@ -682,6 +682,15 @@ def adjust_database_uri(cls, uri, selected_schema=None):
return uri

@classmethod
def extract_error_message(cls, e):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit this could be:

try:
   msg = e.message.status.errorMessage
except:
   msg = str(e)
return msg

@coveralls
Copy link

coveralls commented Aug 16, 2017 •
edited

Coverage Status

Coverage decreased (-0.06%) to 69.362% when pulling 5354986 on mistercrunch:hive_err_msg into 232a5c3 on apache:master.

@mistercrunch mistercrunch merged commit 0aa3d2a into apache:master Aug 17, 2017
@mistercrunch mistercrunch deleted the hive_err_msg branch August 17, 2017 00:40
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx xrmx approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hive] better error messages
3 participants
@mistercrunch @coveralls @xrmx