Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hive] improve error messages #3305

Merged
merged 2 commits into from
Aug 17, 2017
Merged

[hive] improve error messages #3305

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
628bc33
[hive] improve error messages
mistercrunch Aug 16, 2017
5354986
Addressing comments
mistercrunch Aug 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions superset/db_engine_specs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,14 @@ def adjust_database_uri(cls, uri, selected_schema=None):
uri.database = selected_schema
return uri

@classmethod
def extract_error_message(cls, e):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit this could be:

try:
   msg = e.message.status.errorMessage
except:
   msg = str(e)
return msg

try:
msg = e.message.status.errorMessage
except:
msg = str(e)
return msg

@classmethod
def progress(cls, log_lines):
total_jobs = 1 # assuming there's at least 1 job
Expand Down