Implement the column config and row config in pivot table #4394

ShirmineWang · 2018-02-09T08:39:43Z

Column configuration:

User can set general configuration and conditional configuration
for every column, not just metric.
The configuration includes color configuration, font weight
configuration and format configuration.
Add the ColumnControl for user to set the column configuration.
Add the action SET_FETCH_COLUMNS for ColumnControl to get the
newest columns rendered in the chart.
Add the process logic in the pivot table for different situation
in column configuration.
Add the ColumnControl_spec to test functions in the ColumnControl.

Row configuration:

User can set color and font weight for rows containing certain cell.
Add the RowControl for user to set the row configuration.
Add the process logic in the pivot table for different situation
in row configuration.
Add the RowControl_spec to test functions in the RowControl.

Priority of column config and row config:

User can set priority themselves.
Add the checkbox for user to set the priority.
By default, the column configution has high priority than row
configuration.

in pivot table. Column configuration: - User can set general configuration and conditional configuration for every column, not just metric. - The configuration includes color configuration, font weight configuration and format configuration. - Add the ColumnControl for user to set the column configuration. - Add the action `SET_FETCH_COLUMNS` for ColumnControl to get the newest columns rendered in the chart. - Add the process logic in the pivot table for different situation in column configuration. - Add the ColumnControl_spec to test functions in the ColumnControl. Row configuration: - User can set color and font weight for rows containing certain cell. - Add the RowControl for user to set the row configuration. - Add the process logic in the pivot table for different situation in row configuration. - Add the RowControl_spec to test functions in the RowControl. Priority of column config and row config: - User can set priority themselves. - Add the checkbox for user to set the priority. - By default, the column configution has high priority than row configuration.

xiaohanyu · 2018-02-09T09:26:49Z

Ref issues:

Add ability to color cells on Pivot Tables #3416

mistercrunch · 2018-02-13T05:24:48Z

Oh neat! Can we get a few screenshots to get an idea of how this looks?

xiaohanyu · 2018-02-13T05:39:58Z

Here's a gif: https://user-images.githubusercontent.com/1164623/35914802-9a8c8442-0c3f-11e8-8806-6639c5a1b77d.gif

I'll update a few more pics today.

xiaohanyu · 2018-02-13T06:05:30Z

Hi, here's the "welcome" page for slice with pivot table viz type, we add two new sections in the left side menu:

Expanding column configuration:

Expanding row configuration:

xiaohanyu · 2018-02-13T06:05:45Z

Some test cases

column configuration:

Set all cell's background color to red (by selecting only the metric)

Set one column's background color to red (by selecting metric and columns)

Set all cell's background color to blue and set different color for different columns (first by selecting metric and set background color, then set color for different columns under metrics)

Text alignment for specific column (by setting text align for metric or column)

Specific formatting for specific column:

column configuration with conditional formatting

Set all cells with value greater than 20000 to red color background and bold font:

Set Set all cells of a specific column with value greater than 20000 to yellow color background:

Together with background settings from above, we can mark cells whose value is greater than 20000 with yellow color, while other cells with green color by setting background color for the whole column.

xiaohanyu · 2018-02-13T06:37:39Z

column configuration for font option:

set all cells to bold font by setting a wildcard conditional expression like > 0.

set specific column font to bold:

set specific cells to bold font in a column:

xiaohanyu · 2018-02-13T06:41:05Z

Row configuration:

Set rows's background color to red if content in that row contains specific word:

Set rows's font to bold if content in that row contains specific word:

xiaohanyu · 2018-02-13T06:44:16Z

Priority between column configuration and row configuration:

Column configuration has high priority over row configuration (this is the default option):

Column configuration has low priority over row configuration:

A new "Prioritize Row Configuration" in "Pivot Opitions":

xiaohanyu · 2018-02-13T06:53:52Z

Hi, @mistercrunch

Above is the overall features of this so-called "column and row configuration". Actually, we have used superset for almost one year, and designed this feature from bottom up, improve piece by piece, and finally proposed this patch for community.

The basic design is:

should be a purely frontend implementation based on datatables state save and restore
put column configuration and row configurations settings to formData, just utilize superset's existing tools to save and restore table state

There're maybe some issues though:

store column/row configuration may cause url too long for browsers and backend server, need to adjust existing nginx or some other backend settings to accept long GET urls
- solution: maybe we should switch from GET to POST for queries to avoid this kind of long url problem?
frontend performance: when user has complicated settings and big data tables, it really takes some time to render the whole table, need to figure out a way to improve this.

We're definitely sure that there should be some improvements over the UI/UX design, to make it more intuitive, so we propose this to community asking some feedback. And we think that this is a good starting point.

This feature is mainly designed for dashboard readers, they may be leaders of the team, just glance over multiple dashboard in minutes, and they need colors to mark the most important metrics in a table for them.

That's all, thanks.

xrmx · 2018-02-13T09:06:21Z

superset/viz.py

@@ -584,8 +584,12 @@ def get_data(self, df):
        # Display metrics side by side with each column
        if self.form_data.get('combine_metric'):
            df = df.stack(0).unstack()
+        parsed_columns = list(map(


Not sure if this code is needed / wanted but maps in python are a bit convoluted. What about using list comprehension?

to_list = lambda x: [six.text_type(z) for z in x] if isinstance(x, tuple) else [x] parsed_columns = [to_list(x) for x in df.columns.values]

Yeah, OK for us. Guido don't like map/reduce/filter, LOL.

graceguo-supercat · 2018-02-14T01:40:07Z

@xiaohanyu We had a PR to convert all charting request method from GET to POST here:
#3993
I just have it merged. Please let me know if it works for you!

mistercrunch · 2018-02-14T02:01:39Z

Haven't dug deep in this PR yet, but it looks like colors are quite binary, as opposed to a spectrum. Seems like many may want more of a gradient to visualize their data more like a heatmap. ?

xiaohanyu · 2018-02-14T05:44:53Z

@graceguo-supercat will definitely rebase the code.

xiaohanyu · 2018-02-14T05:51:12Z

@mistercrunch Yes, we only provide binary colors in this PR. However, we've already implemented a new internal feature that provides some gradient options by length or by color change, here're some screenshots:

a new table progress bar settings section

gradient by length:

gradient by color scale

We think this kind of feature should be proposed as a new feature, and we still need some time to rebase own internal patch.

mistercrunch · 2018-02-14T06:17:19Z

Oh that looks neat!

Stevie337 · 2018-04-05T07:23:19Z

Hi All,

Has this PR already been pushed?? Ifso in what build would this be?

mistercrunch · 2018-04-05T17:00:13Z

@michellethomas do you think this conflicts with your goal of deprecating datatables?

CasperLiu · 2018-04-24T09:09:49Z

Hi xiaohanyu,

This PR looks beautiful and great, and is what we just need.

Appreciated your work!

Which superset version will this PR go to?

Regards
Jiaxu,
刘佳旭

xiaohanyu · 2018-04-24T09:47:45Z

@CasperLiu Hi, we worked this PR on superset 0.22.1 version, so I think you can cherry pick this PR if you like it.

As you can see, the official superset decides to switch http request method from GET and POST, and it seems that deprecating datatable.js is WIP. So I'm afraid that this PR will not work for versions later than 0.22.1.

Besides, my team are busy again these days, so we don't have additional time to rebase this PR, sorry...

pauldx · 2018-06-12T19:20:19Z

@xiaohanyu Hi , Like the new PR. Any ETA when and what Superset release will have it ? thanks and good work . - Paul

krishna9626 · 2018-11-19T06:48:41Z

When will we expect this feature in superset?

Saajan · 2018-12-11T08:28:42Z

Any update on this. Can someone implement this in new version .

kalimuthu123 · 2019-02-06T13:46:21Z

is it work for 0.28 version

mshiner · 2019-03-14T09:24:35Z

I'm very interested in this feature as well - any news?

mistercrunch · 2019-03-15T00:58:32Z

I'd recommend making this a plugin.

kuvsh · 2019-03-20T14:41:03Z

Hello! I'm very intrested in this feature. When it will be released?

mistercrunch · 2019-03-20T15:18:21Z

Please resubmit as plugin!

rohitpawar2811 · 2023-05-02T10:01:02Z

@mistercrunch @xiaohanyu Hii I have to firstly ask that the row-configuration feature has been removed from superset-2.0.0 ?.
If yes then my question is why we removed that any issues faced on running that thing

ShirmineWang force-pushed the feature-column-and-row-configuration-in-pivot-table branch from 546a572 to 66408ad Compare February 9, 2018 09:12

ShirmineWang mentioned this pull request Feb 9, 2018

Add ability to color cells on Pivot Tables #3416

Closed

xrmx reviewed Feb 13, 2018

View reviewed changes

kristw added the enhancement:request Enhancement request submitted by anyone from the community label Jan 23, 2019

mistercrunch closed this Mar 20, 2019

kalimuthu123 mentioned this pull request Sep 19, 2019

Pivot Table Conditional Formatting on Cells - Add Colour to Cells #8236

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement the column config and row config in pivot table #4394

Implement the column config and row config in pivot table #4394

ShirmineWang commented Feb 9, 2018

xiaohanyu commented Feb 9, 2018

mistercrunch commented Feb 13, 2018

xiaohanyu commented Feb 13, 2018 •

edited

Loading

xiaohanyu commented Feb 13, 2018

xiaohanyu commented Feb 13, 2018 •

edited

Loading

xiaohanyu commented Feb 13, 2018

xiaohanyu commented Feb 13, 2018

xiaohanyu commented Feb 13, 2018

xiaohanyu commented Feb 13, 2018 •

edited

Loading

xrmx Feb 13, 2018

xiaohanyu Feb 13, 2018 •

edited

Loading

graceguo-supercat commented Feb 14, 2018

mistercrunch commented Feb 14, 2018

xiaohanyu commented Feb 14, 2018

xiaohanyu commented Feb 14, 2018 •

edited

Loading

mistercrunch commented Feb 14, 2018

Stevie337 commented Apr 5, 2018

mistercrunch commented Apr 5, 2018

CasperLiu commented Apr 24, 2018

xiaohanyu commented Apr 24, 2018

pauldx commented Jun 12, 2018 •

edited

Loading

krishna9626 commented Nov 19, 2018

Saajan commented Dec 11, 2018

kalimuthu123 commented Feb 6, 2019

mshiner commented Mar 14, 2019

mistercrunch commented Mar 15, 2019

kuvsh commented Mar 20, 2019

mistercrunch commented Mar 20, 2019

rohitpawar2811 commented May 2, 2023

Implement the column config and row config in pivot table #4394

Implement the column config and row config in pivot table #4394

Conversation

ShirmineWang commented Feb 9, 2018

xiaohanyu commented Feb 9, 2018

mistercrunch commented Feb 13, 2018

xiaohanyu commented Feb 13, 2018 • edited Loading

xiaohanyu commented Feb 13, 2018

xiaohanyu commented Feb 13, 2018 • edited Loading

column configuration:

column configuration with conditional formatting

xiaohanyu commented Feb 13, 2018

column configuration for font option:

xiaohanyu commented Feb 13, 2018

Row configuration:

xiaohanyu commented Feb 13, 2018

Priority between column configuration and row configuration:

xiaohanyu commented Feb 13, 2018 • edited Loading

xrmx Feb 13, 2018

Choose a reason for hiding this comment

xiaohanyu Feb 13, 2018 • edited Loading

Choose a reason for hiding this comment

graceguo-supercat commented Feb 14, 2018

mistercrunch commented Feb 14, 2018

xiaohanyu commented Feb 14, 2018

xiaohanyu commented Feb 14, 2018 • edited Loading

a new table progress bar settings section

gradient by length:

gradient by color scale

mistercrunch commented Feb 14, 2018

Stevie337 commented Apr 5, 2018

mistercrunch commented Apr 5, 2018

CasperLiu commented Apr 24, 2018

xiaohanyu commented Apr 24, 2018

pauldx commented Jun 12, 2018 • edited Loading

krishna9626 commented Nov 19, 2018

Saajan commented Dec 11, 2018

kalimuthu123 commented Feb 6, 2019

mshiner commented Mar 14, 2019

mistercrunch commented Mar 15, 2019

kuvsh commented Mar 20, 2019

mistercrunch commented Mar 20, 2019

rohitpawar2811 commented May 2, 2023

xiaohanyu commented Feb 13, 2018 •

edited

Loading

xiaohanyu commented Feb 13, 2018 •

edited

Loading

xiaohanyu commented Feb 13, 2018 •

edited

Loading

xiaohanyu Feb 13, 2018 •

edited

Loading

xiaohanyu commented Feb 14, 2018 •

edited

Loading

pauldx commented Jun 12, 2018 •

edited

Loading