Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 7620: Start removing dependencies on requests #7643

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@sturmer
Copy link

commented Jun 4, 2019

CATEGORY

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Make dependency on requests and pydruid connector optional. Note: the first commit is @villebro 's work.

TEST PLAN

It might require some @unittest.skipUnless, I will check the result of the Travis tests first.

ADDITIONAL INFORMATION

Fixes #7620.

  • Has associated issue: 7620.
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@mistercrunch , @villebro

@pull-request-size pull-request-size bot added the size/S label Jun 4, 2019

sturmer added some commits Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.