Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[function] Add a built-in function #325

Merged
merged 21 commits into from
Jun 2, 2020
Merged

[function] Add a built-in function #325

merged 21 commits into from
Jun 2, 2020

Conversation

qinkunbao
Copy link
Member

@qinkunbao qinkunbao commented Jun 1, 2020

Description

Add a built-in function.

Fixes # (issue)

Type of change (select or add applied and delete the others)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just sync with upstream third-party crates

How has this been tested?

Checklist

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the tests pass (see CI results).
  • Make sure your code lints/format.

@mssun
Copy link
Member

mssun commented Jun 1, 2020

Thanks.

You can add this example in the test by adding it here:

python3 ${TEACLAVE_PROJECT_ROOT}/examples/python/mesapy_echo.py

Then run make run-examples to test all examples.

@qinkunbao
Copy link
Member Author

OK, I added this example and all tests passed.

@mssun
Copy link
Member

mssun commented Jun 2, 2020

Please use make format to format all rust code.

@qinkunbao qinkunbao marked this pull request as ready for review June 2, 2020 02:00
function/src/online_decrypt.rs Outdated Show resolved Hide resolved
function/src/online_decrypt.rs Outdated Show resolved Hide resolved
executor/Cargo.toml Outdated Show resolved Hide resolved
executor/Cargo.toml Outdated Show resolved Hide resolved
examples/python/builtin_online_decrypt.py Outdated Show resolved Hide resolved
examples/python/builtin_online_decrypt.py Outdated Show resolved Hide resolved
examples/python/builtin_online_decrypt.py Outdated Show resolved Hide resolved
executor/src/builtin.rs Outdated Show resolved Hide resolved
function/src/online_decrypt.rs Outdated Show resolved Hide resolved
@mssun mssun self-requested a review June 2, 2020 03:49
@qinkunbao
Copy link
Member Author

Thank you for the feedback. All requested changes are addressed now.

Copy link
Member

@mssun mssun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm building/testing the code. Will merge it if passed. Thanks!

@mssun mssun merged commit 7bd059a into apache:master Jun 2, 2020
@mssun
Copy link
Member

mssun commented Jun 2, 2020

Merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants