Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traffic Ops does not ignore active ANY_MAP Delivery Services when generating CRConfig #1121

Closed
rawlinp opened this issue Sep 1, 2017 · 3 comments
Closed

Traffic Ops does not ignore active ANY_MAP Delivery Services when generating CRConfig #1121

rawlinp opened this issue Sep 1, 2017 · 3 comments
Labels
bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops

Comments

@rawlinp
Copy link
Contributor

rawlinp commented Sep 1, 2017

According to the documentation for Delivery Services:

ANY_MAP is not known to Traffic Router. For this deliveryservice, the “Raw remap text” field in the input form will be used as the remap line on the cache.

However, Traffic Ops treats it similarly to an HTTP Delivery Service when generating CRConfig, and this is only avoided by setting the ANY_MAP Delivery Service to inactive. Rather, Traffic Ops should filter out ANY_MAP Delivery Services when generating the CRConfig so that Traffic Router doesn't treat them like an HTTP Delivery Service.
@rawlinp rawlinp mentioned this issue Sep 9, 2017
Closed
@mitchell852 mitchell852 added bug something isn't working as intended Traffic Ops related to Traffic Ops labels Sep 12, 2017
@mitchell852
Copy link
Member

@rawlinp - can you put a severity level label on this? trivial, minor, major, critical...or actually, since you can't attach labels, reach out to me and i'll attach it for you

@rawlinp
Copy link
Contributor Author

rawlinp commented Dec 19, 2017

@mitchell852 I'd say it's probably minor because setting it to inactive if it's causing problems is easy enough.

@rawlinp rawlinp mentioned this issue Dec 19, 2017
Merged
@mitchell852 mitchell852 added the low impact affects only a small portion of a CDN, and cannot itself break one label Dec 19, 2017
@rawlinp
Copy link
Contributor Author

rawlinp commented Jun 20, 2018

I fixed this in the Perl API , but it looks like it was overlooked in the Golang rewrite of the CRConfig endpoints and is now an issue again.

@rawlinp rawlinp changed the title Traffic Ops does not ignore ANY_MAP Delivery Services when generating CRConfig Traffic Ops does not ignore active ANY_MAP Delivery Services when generating CRConfig Jun 20, 2018
@rawlinp rawlinp mentioned this issue Jun 20, 2018
Merged
rawlinp pushed a commit to rawlinp/trafficcontrol that referenced this issue Jun 20, 2018
Fix TO Go CRConfig generation to ignore active ANY_MAP DSes
fe7b03e 
This is a regression from the Perl version of the CRConfig generation
which ignores active ANY_MAP DSes.

Fixes apache#1121
rob05c pushed a commit that referenced this issue Jun 20, 2018
@rob05c
Fix TO Go CRConfig generation to ignore active ANY_MAP DSes
3c67eb3 
This is a regression from the Perl version of the CRConfig generation
which ignores active ANY_MAP DSes.

Fixes #1121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitchell852 @rawlinp