Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-500] Creating/Updating a Delivery Service via API has length constraint on displayName of 48, but no such constraint in UI code #994

Closed
limited opened this issue Aug 29, 2017 · 1 comment
Labels
bug something isn't working as intended good first issue first-time committers will find this easy to resolve low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1

Comments

@limited
Copy link
Contributor

limited commented Aug 29, 2017

Creating/Updating a Delivery Service via API code has length constraint on `displayName` of 48, but there is no such constraint in the UI code so any user can update the value to more than 48 characters. The Database field is Text which is described as "variable unlimited length" in the Postgres documentation. However, the value may be limited by the GUI field if such a constraint exists.

NOTE: The GET methods for /api/1.2/deliveryservices does not check the length on the `displayName` field, so, it will return whatever is in the database for `displayName`.

Work Around: Upon getting the Delivery Service information from the API, in order to update/create the Delivery Service via the API you will need to limit the number of characters in the `displayName` to 48.

NOTE: Other versions of Traffic Ops may be affected.

Author: Robert Scrimo
JIRA Link: https://issues.apache.org/jira/browse/TC-500
Found Version: 2.1.0

@limited limited added this to the 2.2.0 milestone Aug 29, 2017
@limited limited added bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops API labels Aug 29, 2017
@mitchell852 mitchell852 added the Traffic Ops related to Traffic Ops label Aug 31, 2017
@mitchell852 mitchell852 added the Traffic Portal v1 related to Traffic Portal version 1 label Sep 26, 2017
@mitchell852 mitchell852 removed this from the 2.2.0 milestone Oct 17, 2017
@mitchell852 mitchell852 moved this from Intake to In Backlog in Traffic Portal v1 (TO UI replacement) Dec 8, 2017
@mitchell852 mitchell852 self-assigned this Dec 19, 2017
@mitchell852 mitchell852 added the good first issue first-time committers will find this easy to resolve label Jan 19, 2018
@mitchell852 mitchell852 removed their assignment Jan 19, 2018
@mitchell852
Copy link
Member

the maxlength of 48 is enforced in the UI and the API already. Maybe the code was updated after this issue was created.

@mitchell852 mitchell852 moved this from In Backlog to Completed in Traffic Portal v1 (TO UI replacement) Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended good first issue first-time committers will find this easy to resolve low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1
Projects
No open projects
Development

No branches or pull requests

2 participants