Fix TO Go CRConfig to omit null missLocations #2221
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed the Golang CRConfig to do what Perl does: omit the
missLocation
field if it's null in the database.Specifically, the Go
MissLocation
field isomitempty
, but was always being assigned an object (MissLocation: &tc.CRConfigLatitudeLongitudeShort{}
). This changes it to only assign an object if the miss location exists.This also warns if Lat or Lon is set, but not both. This is different from Perl, which would put whichever was set in the CRConfig. It's never useful to have Lat without Lon, so IMO that should be considered a bug, and warned, which this does.
Long term, we should make it impossible in the DB and UI to set Lat without Lon. But that's a bigger change.