[TC-251] Fixed an issue where Traffic Ops was not correctly refreshing DNSSEC keys #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… updated it so it actually runs the forked process in the background instead of blocking
|
Closing this as a better solution is provided in #521 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to fix fork_and_daemonize() so that it would do what we needed. We want that method to fork off a child and return while the child does its thing in the backgroup (without waiting for the child). This functionality was changed in 2.0 because the previous implementation was causing issues with processes that use waitpid(), see TC-158. The new method is similar to the pre 2.0 method except it does not set a the SIGCHILD handler to IGNORE and it cleans up completed child processes each time it is called. This hopefully satisfies the requirements of running asynchronously while also not leaving zombie processes and using up all of the traffic_ops workers.