[TC-265] adds secondary psel qstring handling at profile level #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangogh
reviewed
May 2, 2017
| if (defined($hash_key_ids)) { | ||
| my @tmp_list = split( /,/, $hash_key_ids); | ||
|
|
||
| # find the minimum of the two list sizes |
There was a problem hiding this comment.
I can see that's what you're trying to do -- but why?
There was a problem hiding this comment.
just spent 5 minutes figuring out what this method is doing. Figured that out, but I still don't know why -- comments needed, please....
There was a problem hiding this comment.
none of that should be in there, actually. let me clean that up. must have had some leakage from another branch.
dg4prez
force-pushed
the
profile_psel_qstring
branch
from
6221eeb
to
7382bf7
Compare
|
where's the Jira issue for this? |
dg4prez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a psel.qstring_handling parameter to be set to a profile, overriding all qstring handling except when specified by a delivery service profile. Useful if you have multiple edge tiers but need different qstring values.