Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-270] - cache_stats - query from summarized data (continuous queries) instead of raw data #545

Closed
wants to merge 1 commit into from

Conversation

mitchell852
Copy link
Member

No description provided.

GROUP BY time($args->{interval}), cdn"
);
my $query = qq[SELECT mean(value), percentile(value, 5), percentile(value, 95), percentile(value, 98), min(value), max(value), sum(value), count(value)
FROM "monthly"."$args->{series_name}.cdn.1min"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably want a way to change the retention policy here. Either through configs or args. hard-coding to "monthly" could lead to issues.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RT name is also hard-coded in the deliveryservice_stats endpoint - https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/Extensions/TrafficStats/Builder/DeliveryServiceStatsBuilder.pm#L81

How about I create a new Jira and a subsequent PR that removes hardcoded RT references from both cache_stats and deliveryservice_stats endpoints and maybe puts the RT names in this file: https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/conf/production/influxdb.conf

cdn ORDER BY asc"
);
my $query = qq[SELECT sum(value)/count(value)
FROM "monthly"."$args->{series_name}.cdn.1min"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, we probably want a way to config the retention policy to use.

@asfgit asfgit closed this in 63f6abf May 5, 2017
@mitchell852 mitchell852 deleted the tc-270-cache-stats-cq branch December 28, 2017 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants