Skip to content

Commit

Permalink
[MINOR] Remove unused config SHUFFLE_EXPIRED_TIMEOUT_MS (#835)
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?
Remove unused config `SHUFFLE_EXPIRED_TIMEOUT_MS`.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
No need.
  • Loading branch information
smallzhongfeng committed Apr 21, 2023
1 parent 893e4ee commit 3cbc60e
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ public static void setupServers(@TempDir File tmpDir) throws Exception {
shuffleServerConf.setDouble(ShuffleServerConf.HIGH_WATER_MARK_OF_WRITE, 100.0);
shuffleServerConf.setLong(ShuffleServerConf.DISK_CAPACITY, 1024L * 1024L * 100);
shuffleServerConf.setLong(ShuffleServerConf.PENDING_EVENT_TIMEOUT_SEC, 30L);
shuffleServerConf.setLong(ShuffleServerConf.SHUFFLE_EXPIRED_TIMEOUT_MS, 5000L);
shuffleServerConf.setLong(ShuffleServerConf.SERVER_APP_EXPIRED_WITHOUT_HEARTBEAT, 60L * 1000L * 60L);
shuffleServerConf.setLong(ShuffleServerConf.SERVER_COMMIT_TIMEOUT, 20L * 1000L);
shuffleServerConf.setString(ShuffleServerConf.RSS_STORAGE_TYPE, StorageType.LOCALFILE_HDFS.name());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ public static void setupServers(@TempDir File tmpDir) throws Exception {
shuffleServerConf.setDouble(ShuffleServerConf.HIGH_WATER_MARK_OF_WRITE, 100.0);
shuffleServerConf.setLong(ShuffleServerConf.DISK_CAPACITY, 1024L * 1024L * 100);
shuffleServerConf.setLong(ShuffleServerConf.PENDING_EVENT_TIMEOUT_SEC, 30L);
shuffleServerConf.setLong(ShuffleServerConf.SHUFFLE_EXPIRED_TIMEOUT_MS, 5000L);
shuffleServerConf.setLong(ShuffleServerConf.SERVER_APP_EXPIRED_WITHOUT_HEARTBEAT, 60L * 1000L * 60L);
shuffleServerConf.setLong(ShuffleServerConf.SERVER_COMMIT_TIMEOUT, 20L * 1000L);
shuffleServerConf.setString(ShuffleServerConf.RSS_STORAGE_TYPE, StorageType.LOCALFILE_HDFS.name());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -201,14 +201,6 @@ public class ShuffleServerConf extends RssBaseConf {
.withDescription("The maximum ratio of disk that could be used as shuffle server. This is only effective "
+ "when `rss.server.disk.capacity` is not explicitly set");

public static final ConfigOption<Long> SHUFFLE_EXPIRED_TIMEOUT_MS = ConfigOptions
.key("rss.server.shuffle.expired.timeout.ms")
.longType()
.checkValue(ConfigUtils.POSITIVE_LONG_VALIDATOR, "shuffle expired timeout must be positive")
.defaultValue(60L * 1000 * 2)
.withDescription("If the shuffle is not read for the long time, and shuffle is uploaded totally,"
+ " , we can delete the shuffle");

public static final ConfigOption<Long> SERVER_SHUFFLE_INDEX_SIZE_HINT = ConfigOptions
.key("rss.server.index.size.hint")
.longType()
Expand Down

0 comments on commit 3cbc60e

Please sign in to comment.