Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Remove unused config SHUFFLE_EXPIRED_TIMEOUT_MS #835

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

smallzhongfeng
Copy link
Contributor

What changes were proposed in this pull request?

Remove unused config SHUFFLE_EXPIRED_TIMEOUT_MS.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No need.

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Merging #835 (557096e) into master (893e4ee) will increase coverage by 2.18%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #835      +/-   ##
============================================
+ Coverage     56.67%   58.86%   +2.18%     
- Complexity     2070     2071       +1     
============================================
  Files           312      292      -20     
  Lines         15390    13024    -2366     
  Branches       1239     1239              
============================================
- Hits           8723     7667    -1056     
+ Misses         6157     4920    -1237     
+ Partials        510      437      -73     
Impacted Files Coverage Δ
...a/org/apache/uniffle/server/ShuffleServerConf.java 99.42% <ø> (-0.01%) ⬇️

... and 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @smallzhongfeng , Merged to Master

@jerqi jerqi merged commit 3cbc60e into apache:master Apr 21, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants