Skip to content

Commit

Permalink
Change default checkstyle severity to error (#57)
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

Change default checkstyle severity to error.

### Why are the changes needed?

In common sense, "warning" is something can be ignored.
It is better to use "error" to mean something must be fixed. 
And current CI workflow displays "Summary of failures" by filtering errors.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Example of checkstyle failure, click "Summary of failures" to see the filtered result.
https://github.com/kaijchen/incubator-uniffle/runs/7319512298?check_suite_focus=true
  • Loading branch information
kaijchen committed Jul 15, 2022
1 parent aa02ee6 commit e343b93
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
3 changes: 0 additions & 3 deletions checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
<module name = "Checker">
<property name="charset" value="UTF-8"/>

<property name="severity" value="warning"/>

<property name="fileExtensions" value="java, properties, xml"/>
<!-- Excludes all 'module-info.java' files -->
<!-- See https://checkstyle.org/config_filefilters.html -->
Expand Down Expand Up @@ -288,7 +286,6 @@
<module name="VariableDeclarationUsageDistance"/>
<module name="CustomImportOrder">
<!-- new add -->
<property name="severity" value="WARNING"/>
<property name="sortImportsInGroupAlphabetically" value="true"/>
<property name="specialImportsRegExp" value="^org\.apache\.uniffle"/>
<property name="standardPackageRegExp" value="^java\.|^javax\."/>
Expand Down
1 change: 0 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -797,7 +797,6 @@
<failsOnError>true</failsOnError>
<linkXRef>false</linkXRef>
<failOnViolation>true</failOnViolation>
<violationSeverity>warning</violationSeverity>
</configuration>
<dependencies>
<dependency>
Expand Down

0 comments on commit e343b93

Please sign in to comment.