Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Change default checkstyle severity to error #57

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

kaijchen
Copy link
Contributor

What changes were proposed in this pull request?

Change default checkstyle severity to error.

Why are the changes needed?

In common sense, "warning" is something can be ignored.
It is better to use "error" to mean something must be fixed.
And current CI workflow displays "Summary of failures" by filtering errors.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Example of checkstyle failure, click "Summary of failures" to see the filtered result.
https://github.com/kaijchen/incubator-uniffle/runs/7319512298?check_suite_focus=true

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #57 (0beea7f) into master (aa02ee6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #57   +/-   ##
=========================================
  Coverage     54.89%   54.89%           
  Complexity     1092     1092           
=========================================
  Files           146      146           
  Lines          7775     7775           
  Branches        749      749           
=========================================
  Hits           4268     4268           
  Misses         3270     3270           
  Partials        237      237           
Impacted Files Coverage Δ
...storage/handler/impl/DataSkippableReadHandler.java 81.25% <0.00%> (-3.13%) ⬇️
...e/uniffle/server/storage/SingleStorageManager.java 67.21% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa02ee6...0beea7f. Read the comment docs.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi merged commit e343b93 into apache:master Jul 15, 2022
@kaijchen kaijchen deleted the checkstyle branch July 15, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants