Skip to content

Commit

Permalink
[MINOR] fix: Error logs upload fail (#917)
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

https://github.com/apache/incubator-uniffle/actions/runs/5141497645/jobs/9254329542?pr=916 fail, but error logs upload fail, so we can't analyze the cause.

Upload logs are below: 

```
Run actions/upload-artifact@v3
With the provided path, there will be 53 files uploaded
Starting artifact upload
For more detailed logs during the artifact upload process, enable step-debugging: https://docs.github.com/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging#enabling-step-debug-logging
Error: Artifact name is not valid: test-reports-mr:hadoop3.2. Contains the following character:  Colon :
          
Invalid characters include:  Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n, Backslash \, Forward slash /
          
These characters are not allowed in the artifact name due to limitations with certain file systems such as NTFS. To maintain file system agnostic behavior, these characters are intentionally not allowed to prevent potential problems with downloads on different file systems.
```

### Why are the changes needed?

reproduce error describe in https://github.com/apache/incubator-uniffle/actions/runs/5141497645/jobs/9254329542?pr=916

Co-authored-by: zhengchenyu001 <zhengchenyu001@ke.com>
  • Loading branch information
zhengchenyu and zhengchenyu001 committed Jun 2, 2023
1 parent 6471c5e commit f7c1c43
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/parallel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,16 @@ jobs:
strategy:
matrix:
profile:
# Pay attention! Don't use profile with character ':'!
- spark2
- spark2.3
- spark3.0
- spark3
- spark3.2
- spark3.2.0
- spark3.3
- mr:hadoop2.8
- mr:hadoop3.2
- mr-hadoop2.8
- mr-hadoop3.2
- tez
fail-fast: false
name: -P${{ matrix.profile }}
Expand All @@ -83,7 +84,7 @@ jobs:
- name: Execute `mvn ${{ inputs.maven-args }} -P${{ matrix.profile }}`
run: |
PROFILES="${{ matrix.profile }}"
PROFILES=${PROFILES/:/,}
PROFILES=${PROFILES/-/,}
mvn -B -fae ${{ inputs.maven-args }} -P${PROFILES} | tee /tmp/maven.log
shell: bash
- name: Summary of failures
Expand Down

0 comments on commit f7c1c43

Please sign in to comment.