Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] fix: Error logs upload fail #917

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Conversation

zhengchenyu
Copy link
Collaborator

What changes were proposed in this pull request?

https://github.com/apache/incubator-uniffle/actions/runs/5141497645/jobs/9254329542?pr=916 fail, but error logs upload fail, so we can't analyze the cause.

Upload logs are below:

Run actions/upload-artifact@v3
With the provided path, there will be 53 files uploaded
Starting artifact upload
For more detailed logs during the artifact upload process, enable step-debugging: https://docs.github.com/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging#enabling-step-debug-logging
Error: Artifact name is not valid: test-reports-mr:hadoop3.2. Contains the following character:  Colon :
          
Invalid characters include:  Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n, Backslash \, Forward slash /
          
These characters are not allowed in the artifact name due to limitations with certain file systems such as NTFS. To maintain file system agnostic behavior, these characters are intentionally not allowed to prevent potential problems with downloads on different file systems.

Why are the changes needed?

reproduce error describe in https://github.com/apache/incubator-uniffle/actions/runs/5141497645/jobs/9254329542?pr=916

@@ -50,15 +50,16 @@ jobs:
strategy:
matrix:
profile:
# Pay attention! Don't use profile with character '-'!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prevent using the symbol colon here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zhengchenyu @cchung100m , merged to master.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #917 (71e838f) into master (c713f39) will increase coverage by 1.97%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #917      +/-   ##
============================================
+ Coverage     55.35%   57.32%   +1.97%     
- Complexity     2237     2246       +9     
============================================
  Files           339      321      -18     
  Lines         16635    14266    -2369     
  Branches       1330     1327       -3     
============================================
- Hits           9208     8178    -1030     
+ Misses         6901     5631    -1270     
+ Partials        526      457      -69     

see 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jerqi
Copy link
Contributor

jerqi commented Jun 2, 2023

test-reports-mr-hadoop3.2.zip
@zhengchenyu I upload the failure log. You can see it. I merge this pr first.

@jerqi jerqi merged commit f7c1c43 into apache:master Jun 2, 2023
26 of 27 checks passed
@zhengchenyu zhengchenyu deleted the fix.workflow branch June 27, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants