-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR] fix: Error logs upload fail #917
Conversation
.github/workflows/parallel.yml
Outdated
@@ -50,15 +50,16 @@ jobs: | |||
strategy: | |||
matrix: | |||
profile: | |||
# Pay attention! Don't use profile with character '-'! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prevent using the symbol colon
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zhengchenyu @cchung100m , merged to master.
Codecov Report
@@ Coverage Diff @@
## master #917 +/- ##
============================================
+ Coverage 55.35% 57.32% +1.97%
- Complexity 2237 2246 +9
============================================
Files 339 321 -18
Lines 16635 14266 -2369
Branches 1330 1327 -3
============================================
- Hits 9208 8178 -1030
+ Misses 6901 5631 -1270
+ Partials 526 457 -69 see 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
test-reports-mr-hadoop3.2.zip |
What changes were proposed in this pull request?
https://github.com/apache/incubator-uniffle/actions/runs/5141497645/jobs/9254329542?pr=916 fail, but error logs upload fail, so we can't analyze the cause.
Upload logs are below:
Why are the changes needed?
reproduce error describe in https://github.com/apache/incubator-uniffle/actions/runs/5141497645/jobs/9254329542?pr=916