Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Add NOTICE-binary #1043

Closed
3 tasks done
jerqi opened this issue Jul 27, 2023 · 0 comments · Fixed by #1097
Closed
3 tasks done

[Improvement] Add NOTICE-binary #1043

jerqi opened this issue Jul 27, 2023 · 0 comments · Fixed by #1097
Assignees
@jerqi
Labels
0.8 For 0.8 version release

Comments

@jerqi
Copy link
Contributor

jerqi commented Jul 27, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

For binary release, we need Notice-binary.

How should we improve?

We need a notice-binary. We can refer to https://github.com/apache/spark/blob/master/NOTICE-binary

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@jerqi jerqi changed the title [Improvement] Add Notice-binary [Improvement] Add NOTICE-binary Jul 27, 2023
@jerqi jerqi added the 0.8 For 0.8 version release label Jul 29, 2023
@jerqi jerqi mentioned this issue Aug 5, 2023
Merged
@jerqi jerqi self-assigned this Aug 5, 2023
jerqi added a commit that referenced this issue Aug 7, 2023
@jerqi
[#1043] chore: Add NOTICE-binary (#1097)
6530ef6 
### What changes were proposed in this pull request?
I unzip the all the jars of release binary. I append all the `NOTICE` files in the `META-INF`.

### Why are the changes needed?
Fix: #1043 

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
No need.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerqi jerqi

Labels
0.8 For 0.8 version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1043] chore: Add NOTICE-binary jerqi/incubator-uniffle
1 participant
@jerqi