Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1043] chore: Add NOTICE-binary #1097

Merged
merged 1 commit into from
Aug 7, 2023
Merged

[#1043] chore: Add NOTICE-binary #1097

merged 1 commit into from
Aug 7, 2023

Conversation

jerqi
Copy link
Contributor

@jerqi jerqi commented Aug 5, 2023

What changes were proposed in this pull request?

I unzip the all the jars of release binary. I append all the NOTICE files in the META-INF.

Why are the changes needed?

Fix: #1043

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No need.

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2023

Codecov Report

Merging #1097 (596aa90) into master (1c99972) will increase coverage by 1.17%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1097      +/-   ##
============================================
+ Coverage     54.06%   55.23%   +1.17%     
  Complexity     2541     2541              
============================================
  Files           386      366      -20     
  Lines         21879    19519    -2360     
  Branches       1812     1812              
============================================
- Hits          11828    10782    -1046     
+ Misses         9355     8110    -1245     
+ Partials        696      627      -69     

see 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jerqi jerqi merged commit 6530ef6 into apache:master Aug 7, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Add NOTICE-binary
3 participants