Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Add LICENSE-binary #1044

Closed
2 of 3 tasks
jerqi opened this issue Jul 27, 2023 · 4 comments · Fixed by #1054
Closed
2 of 3 tasks

[Improvement] Add LICENSE-binary #1044

jerqi opened this issue Jul 27, 2023 · 4 comments · Fixed by #1054
Assignees
@jerqi
Labels
0.8 For 0.8 version release

Comments

@jerqi
Copy link
Contributor

jerqi commented Jul 27, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

For binary release, we should addd LICENSE-binary.

How should we improve?

We should add LICENSE-binary. https://github.com/apache/spark/blob/master/LICENSE-binary

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@jerqi
Copy link
Contributor Author

jerqi commented Jul 27, 2023

@LuciferYang Could you help me?

@LuciferYang
Copy link
Contributor

What kind of help do you need? @jerqi

@jerqi
Copy link
Contributor Author

jerqi commented Jul 27, 2023 •
edited

What kind of help do you need? @jerqi

Could you finish this issue refering to Spark's behaviour?

@LuciferYang
Copy link
Contributor

Ok, let me investigate first

@jerqi jerqi added the 0.8 For 0.8 version release label Jul 29, 2023
@jerqi jerqi mentioned this issue Jul 30, 2023
Merged
@jerqi jerqi self-assigned this Aug 5, 2023
LuciferYang pushed a commit that referenced this issue Aug 14, 2023
@jerqi
[#1044] chore: Add LICENSE-binary (#1054)
72b8698 
### What changes were proposed in this pull request?
Add Notice-binary

### Why are the changes needed?
Fix: #1044
If we want to release binary package, we should have LICENSE-binary. This is very important. The IPMC will check these licenses. 

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
No need.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerqi jerqi

Labels
0.8 For 0.8 version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1044] chore: Add LICENSE-binary jerqi/incubator-uniffle
2 participants
@LuciferYang @jerqi