[#1044] chore: Add LICENSE-binary #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
requested review from
zuston,
advancedxy,
LuciferYang,
kaijchen,
zhengchenyu,
xianjingfeng,
leixm,
jiafuzha,
slfan1989 and
smallzhongfeng
Codecov Report
@@ Coverage Diff @@
## master #1054 +/- ##
============================================
+ Coverage 54.06% 55.24% +1.18%
Complexity 2541 2541
============================================
Files 386 366 -20
Lines 21879 19519 -2360
Branches 1812 1812
============================================
- Hits 11828 10784 -1044
+ Misses 9355 8108 -1247
+ Partials 696 627 -69 see 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LuciferYang
reviewed
Aug 1, 2023
LuciferYang
reviewed
Aug 5, 2023
LICENSE-binary
Outdated
| org.apache.httpcomponents:httpclient | ||
| net.jpountz.lz4:lz4 | ||
| com.google.guava:guava | ||
| com.google.guava::listenablefuture |
|
@LuciferYang Could we merge this pr first? |
LuciferYang
approved these changes
Aug 14, 2023
|
Merged into master. Thanks @jerqi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add Notice-binary
Why are the changes needed?
Fix: #1044
If we want to release binary package, we should have LICENSE-binary. This is very important. The IPMC will check these licenses.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need.