Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] [tez] Fail fast in WriteBufferManager when failed to send shuffle data to shuffle server. #1068

Closed
3 tasks done
zhuyaogai opened this issue Aug 2, 2023 · 0 comments

Comments

@zhuyaogai
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Currently, it only checks for blocks that failed to send after all buffer data has been sent. This check also needs to be moved forward into the addRecord method, allowing it to fail fast.

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
zuston pushed a commit that referenced this issue Aug 3, 2023
…rver. (#1069)

### What changes were proposed in this pull request?

Currently, it only checks for blocks that failed to send after all buffer data has been sent. 
This check also needs to be moved forward into the addRecord method, allowing it to fail fast.

### Why are the changes needed?
Fix: # ([1068](#1068))

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Add more test case in WriteBufferManager.
@jerqi jerqi closed this as completed Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants