Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Incorrect shuffle server status #1173

Closed
3 tasks done
xianjingfeng opened this issue Aug 25, 2023 · 0 comments · Fixed by #1174
Closed
3 tasks done

[Bug] Incorrect shuffle server status #1173

xianjingfeng opened this issue Aug 25, 2023 · 0 comments · Fixed by #1174

Comments

@xianjingfeng
Copy link
Member

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

When i review the pr #1053, I found two problems:

  1. The shuffle server status will be wrong if the server is decommissioning or decommissioned. Let's look at the following code.

for (ServerNode sn : servers.values()) {
if (timestamp - sn.getTimestamp() > heartbeatTimeout) {
LOG.warn("Heartbeat timeout detect, {} will be removed from node list.", sn);
sn.setStatus(ServerStatus.LOST);
lostNodes.add(sn);
unhealthyNodes.remove(sn);
} else if (ServerStatus.UNHEALTHY.equals(sn.getStatus())) {
LOG.warn("Found server {} was unhealthy, will not assign it.", sn);
unhealthyNodes.add(sn);
lostNodes.remove(sn);
} else {
sn.setStatus(ServerStatus.ACTIVE);
lostNodes.remove(sn);
unhealthyNodes.remove(sn);
}

  1. We can't obtain decommissioning or decommissioned server list from API '/api/server/nodes'

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@xianjingfeng xianjingfeng changed the title [Bug] [Bug] Wrong shuffle server status Aug 25, 2023
@xianjingfeng xianjingfeng changed the title [Bug] Wrong shuffle server status [Bug] Incorrect shuffle server status Aug 25, 2023
xianjingfeng added a commit that referenced this issue Aug 28, 2023
### What changes were proposed in this pull request?
Fix incorrect shuffle server status.

### Why are the changes needed?
Fix: #1173

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant