[#1173] fix: incorrect shuffle server status #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1174 +/- ##
============================================
+ Coverage 53.64% 54.77% +1.13%
- Complexity 2581 2582 +1
============================================
Files 391 371 -20
Lines 22406 20043 -2363
Branches 1876 1874 -2
============================================
- Hits 12019 10978 -1041
+ Misses 9679 8429 -1250
+ Partials 708 636 -72
... and 22 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@yl09099 cc |
LGTM~ |
jerqi
approved these changes
Aug 28, 2023
smallzhongfeng
approved these changes
Aug 28, 2023
|
Merged. Thanks all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix incorrect shuffle server status.
Why are the changes needed?
Fix: #1173
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT