-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Replace ConfigEntry with ConfigOption in RssSparkConfig #1302
Comments
@zuston i am new here, let me have a try |
I think at least TezClientConf need 'tez.' prefix, because there is some plase can not direct use TezClientConf.get(...). eg: in RssDAGAppMaster.java
|
We just need to reach some consensus. Then develop MR/Tez/Spark code based on this consensus. This is my idea. Since TezConfiguration/SparkConf is start with "tez."/"spark.", then RssConfig is not start with "tez."/"spark.". If so, TezClientConf should be extended from TezConfiguration. SparkClientConf should be extended from SparkConf. |
Code of Conduct
Search before asking
What would you like to be improved?
We will use the
ConfigOption
to unify all client and server config style. But currently, there are some original code using the ConfigEntry, which is necessary to replace by theConfigEntry
How should we improve?
No response
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: