Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Using configOption in RssMRConfig #1304

Open
2 of 3 tasks
zuston opened this issue Nov 9, 2023 · 1 comment · May be fixed by #1427
Open
2 of 3 tasks

[Improvement] Using configOption in RssMRConfig #1304

zuston opened this issue Nov 9, 2023 · 1 comment · May be fixed by #1427
Assignees
@guixiaowen
Labels
good first issue Good for newcomers

Comments

@zuston
Copy link
Member

zuston commented Nov 9, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Currently, the config key is the single string and the default value should be retrieved explictly, it should be wrapped by ConfigOption

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@zuston zuston added the good first issue Good for newcomers label Nov 9, 2023
@guixiaowen
Copy link
Contributor

@zuston i am new here, let me have a try

guixiaowen added a commit to guixiaowen/incubator-uniffle that referenced this issue Nov 24, 2023
@guixiaowen
[Improvement] Using configOption in RssMRConfig apache#1304
42d59f1
guixiaowen added a commit to guixiaowen/incubator-uniffle that referenced this issue Dec 12, 2023
@guixiaowen
[Improvement] Using configOption in RssMRConfig apache#1304 apache#1333
4376678
@myandpr myandpr linked a pull request Jan 9, 2024 that will close this issue
Open
@zhengchenyu zhengchenyu mentioned this issue Jan 11, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guixiaowen guixiaowen

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1304] Improvement(rss-client-mr): Using configOption in RssMRConfig myandpr/incubator-uniffle
2 participants
@zuston @guixiaowen