-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Under high pressure situations, reading data may encounter the issue of "Blocks read inconsistent" #1620
Comments
The root cause of this issue is #1626, which will be fixed by #1627. And I think maybe we can improve this: when there are flush events being dropped(We need to distinguish a scenario: if it's a speculative write task, we allow them to be dropped), we can fast fail when reading data, instead of lagging until throwing "Blocks read inconsistent" exceptions. |
zuston
pushed a commit
that referenced
this issue
Apr 10, 2024
…rs cache (#1627) ### What changes were proposed in this pull request? Remove the meaningless eventOfUnderStorageManagers. ### Why are the changes needed? Fix #1626 & #1620. It's also a follow-up PR for #383. This cache only makes sense when the event retries after a failure. However, after the event fails, it is not appropriate to continue taking the original storageManager from the cache(because events usually fail due to high IO pressure or disk damage or disk full). In this case, the cache seems to be meaningless, so there is a contradiction here, we should remove it. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested in our env
jerqi
pushed a commit
that referenced
this issue
Apr 30, 2024
…rs cache (#1627) ### What changes were proposed in this pull request? Remove the meaningless eventOfUnderStorageManagers. ### Why are the changes needed? Fix #1626 & #1620. It's also a follow-up PR for #383. This cache only makes sense when the event retries after a failure. However, after the event fails, it is not appropriate to continue taking the original storageManager from the cache(because events usually fail due to high IO pressure or disk damage or disk full). In this case, the cache seems to be meaningless, so there is a contradiction here, we should remove it. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested in our env
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of Conduct
Search before asking
Describe the bug
Affects Version(s)
master
Uniffle Server Log Output
No response
Uniffle Engine Log Output
No response
Uniffle Server Configurations
No response
Uniffle Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: