Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky Test] ShuffleKerberizedHdfsStorageUtilsTest failed when hostname is not "localhost" #708

Closed
3 tasks done
kaijchen opened this issue Mar 10, 2023 · 0 comments · Fixed by #709
Closed
3 tasks done

[Flaky Test] ShuffleKerberizedHdfsStorageUtilsTest failed when hostname is not "localhost" #708

kaijchen opened this issue Mar 10, 2023 · 0 comments · Fixed by #709

Comments

@kaijchen
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the flaky test

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 7.856 s <<< FAILURE! - in org.apache.uniffle.storage.util.ShuffleKerberizedHdfsStorageUtilsTest
[ERROR] testUploadFile{File}  Time elapsed: 0.044 s  <<< ERROR!
java.lang.IllegalArgumentException: Wrong FS: hdfs://localhost:40981/test, expected: hdfs://devcloud:40981
	at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:665)
	at org.apache.hadoop.hdfs.DistributedFileSystem.getPathName(DistributedFileSystem.java:214)
	at org.apache.hadoop.hdfs.DistributedFileSystem$27.doCall(DistributedFileSystem.java:1440)
	at org.apache.hadoop.hdfs.DistributedFileSystem$27.doCall(DistributedFileSystem.java:1437)
	at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
	at org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:1437)
	at org.apache.hadoop.fs.FileSystem.isFile(FileSystem.java:1463)
	at org.apache.uniffle.storage.handler.impl.HdfsFileWriter.initStream(HdfsFileWriter.java:59)
	at org.apache.uniffle.storage.handler.impl.HdfsFileWriter.<init>(HdfsFileWriter.java:54)
	at org.apache.uniffle.storage.util.ShuffleHdfsStorageUtilsTest.createAndRunCases(ShuffleHdfsStorageUtilsTest.java:57)
	at org.apache.uniffle.storage.util.ShuffleKerberizedHdfsStorageUtilsTest.testUploadFile(ShuffleKerberizedHdfsStorageUtilsTest.java:39)

Actions URL

Run locally

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@kaijchen kaijchen mentioned this issue Mar 10, 2023
Merged
jerqi pushed a commit that referenced this issue Mar 10, 2023
@kaijchen
[#708] test: do not assume hostname of hdfs mini-cluster (#709)
1e605c7 
### What changes were proposed in this pull request?

Do not assume hostname in hdfs URL.
Also, let exception be thrown in `ShuffleHdfsStorageUtilsTest` to print verbose message.

### Why are the changes needed?

Fix #708 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Tested manually
advancedxy pushed a commit to advancedxy/incubator-uniffle that referenced this issue Mar 21, 2023
@kaijchen @advancedxy
[apache#708] test: do not assume hostname of hdfs mini-cluster (apach…
496235c 
…e#709)

### What changes were proposed in this pull request?

Do not assume hostname in hdfs URL.
Also, let exception be thrown in `ShuffleHdfsStorageUtilsTest` to print verbose message.

### Why are the changes needed?

Fix apache#708 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Tested manually
xianjingfeng pushed a commit to xianjingfeng/incubator-uniffle that referenced this issue Apr 5, 2023
@kaijchen
[apache#708] test: do not assume hostname of hdfs mini-cluster (apach…
2f16baa 
…e#709)

### What changes were proposed in this pull request?

Do not assume hostname in hdfs URL.
Also, let exception be thrown in `ShuffleHdfsStorageUtilsTest` to print verbose message.

### Why are the changes needed?

Fix apache#708 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Tested manually
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#708] test: do not assume hostname of hdfs mini-cluster kaijchen/incubator-uniffle
1 participant
@kaijchen