[#708] test: do not assume hostname of hdfs mini-cluster #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
previously approved these changes
Mar 10, 2023
kaijchen
changed the title
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
============================================
+ Coverage 60.52% 62.69% +2.16%
Complexity 1847 1847
============================================
Files 228 214 -14
Lines 12744 10780 -1964
Branches 1067 1067
============================================
- Hits 7713 6758 -955
+ Misses 4623 3674 -949
+ Partials 408 348 -60 see 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
approved these changes
Mar 10, 2023
advancedxy
pushed a commit
to advancedxy/incubator-uniffle
that referenced
this pull request
Mar 21, 2023
…e#709) ### What changes were proposed in this pull request? Do not assume hostname in hdfs URL. Also, let exception be thrown in `ShuffleHdfsStorageUtilsTest` to print verbose message. ### Why are the changes needed? Fix apache#708 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested manually
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
…e#709) ### What changes were proposed in this pull request? Do not assume hostname in hdfs URL. Also, let exception be thrown in `ShuffleHdfsStorageUtilsTest` to print verbose message. ### Why are the changes needed? Fix apache#708 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Do not assume hostname in hdfs URL.
Also, let exception be thrown in
ShuffleHdfsStorageUtilsTestto print verbose message.Why are the changes needed?
Fix #708
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tested manually