Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Cli method for blacklist update #768

Closed
2 of 3 tasks
Tracked by #758
smallzhongfeng opened this issue Mar 27, 2023 · 9 comments
Closed
2 of 3 tasks
Tracked by #758

[Subtask] Cli method for blacklist update #768

smallzhongfeng opened this issue Mar 27, 2023 · 9 comments
Assignees
@beryllw
Labels
good first issue Good for newcomers

Comments

@smallzhongfeng
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the subtask

Currently, updates to the blacklist need to rely on the scheduling thread pool for updates, which is relatively inefficient. We can emulate the Hadoop method of updating the config and add clis for updates, which is more efficient.

Parent issue

#758

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@smallzhongfeng smallzhongfeng changed the title [Subtask] Cli method for blacklist update [Subtask] Cli method for blacklist update Mar 27, 2023
@smallzhongfeng smallzhongfeng added the good first issue Good for newcomers label Mar 27, 2023
@smallzhongfeng smallzhongfeng mentioned this issue Mar 27, 2023
Open
9 tasks
@beryllw
Copy link
Contributor

beryllw commented Apr 10, 2023

I'm Interested in this, could you assign it to me？Should I wait for 770 to be completed before starting?

@smallzhongfeng
Copy link
Contributor Author

Of course, I assigned it to you.

@smallzhongfeng
Copy link
Contributor Author

I'm Interested in this, could you assign it to me？Should I wait for 770 to be completed before starting?

Yes, try to wait for #770 to complete.

@jerqi
Copy link
Contributor

jerqi commented Apr 27, 2023

cc @Kwafoor #770 has been finished. You can go ahead.

@beryllw
Copy link
Contributor

beryllw commented May 9, 2023

cc @Kwafoor #770 has been finished. You can go ahead.

OK，I will finish as soon as possible.

beryllw added a commit to beryllw/incubator-uniffle that referenced this issue May 26, 2023
@beryllw
[apache#768] feat(cli): Cli method for blacklist update
3c6fc01
@beryllw
Copy link
Contributor

beryllw commented May 26, 2023

cc @Kwafoor #770 has been finished. You can go ahead.

Almost done, just a little more checking and final touches left. I'll submit it in a few days.

@jerqi
Copy link
Contributor

jerqi commented May 27, 2023 •
edited

cc @Kwafoor #770 has been finished. You can go ahead.

Almost done, just a little more checking and final touches left. I'll submit it in a few days.

@Kwafoor We usually use rest api to control admin service. If we need add api, we would better add rest api. Could we keep consistent with other operation. You can refer to #684

@beryllw
Copy link
Contributor

beryllw commented May 29, 2023

cc @Kwafoor #770 has been finished. You can go ahead.

Almost done, just a little more checking and final touches left. I'll submit it in a few days.

@Kwafoor We usually use rest api to control admin service. If we need add api, we would better add rest api. Could we keep consistent with other operation. You can refer to #684

I have implemented control admin service with reference to yarn through grpc, but I will refer to #684 to see how to achieve it through rest.

beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 5, 2023
@beryllw
[apache#768] feat(cli): Cli method for blacklist update
74fcb9b
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 6, 2023
@beryllw
[apache#768] feat(cli): Cli method for blacklist update
654eada
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 6, 2023
@beryllw
[apache#768] feat(cli): Cli method for blacklist update
dd58995
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 6, 2023
@beryllw
[apache#768] feat(cli): Cli method for blacklist update
dead27b
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 6, 2023
@beryllw
[apache#768] feat(cli): Cli method for blacklist update
22e7f1d
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 6, 2023
@beryllw
[apache#768] feat(cli): Cli method for blacklist update
6add30c
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 7, 2023
@beryllw
[apache#768] feat(cli): Cli method for blacklist update
3655ec3
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 7, 2023
@beryllw
[apache#768] feat(cli): Cli method for blacklist update
5de1db8
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 7, 2023
@beryllw
[apache#768] feat(cli): Cli method for blacklist update
c274b37
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 7, 2023
@beryllw
[apache#768] feat(cli): Cli method for blacklist update
32352c8
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 7, 2023
@beryllw
[apache#768] feat(cli): Cli method for blacklist update
d201d97
@jerqi jerqi mentioned this issue Jun 10, 2023
Merged
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 14, 2023
@beryllw
[apache#768] feat(cli): Cli method for blacklist update
d26cca0
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 15, 2023
@beryllw
[apache#768] feat(cli): Cli method for blacklist update
c9cf0cb
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 15, 2023
@beryllw
[apache#768] fix checkstyle
b8dcd4d
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 15, 2023
@beryllw
[apache#768] add support ssl
73e4168
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 17, 2023
@beryllw
[apache#768] default refresh all checkers set by rss.coordinator.acce…
5c9344c 
…ss.checkers
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 17, 2023
@beryllw
[apache#768] feat(cli): Cli method for blacklist update
c5f0772
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 17, 2023
@beryllw
[apache#768] default refresh all checkers set by rss.coordinator.acce…
2baf5ca 
…ss.checkers
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 17, 2023
@beryllw
[apache#768] default refresh all checkers set by rss.coordinator.acce…
b45f6ce 
…ss.checkers
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 17, 2023
@beryllw
[apache#768] default refresh all checkers set by rss.coordinator.acce…
4e65304 
…ss.checkers
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 17, 2023
@beryllw
[apache#768] feat(cli): Cli method for blacklist update
14f44fd
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 17, 2023
@beryllw
[apache#768] default refresh all checkers set by rss.coordinator.acce…
3975767 
…ss.checkers
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 17, 2023
@beryllw
[apache#768] fix checkstyle
603baf8
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 17, 2023
@beryllw
[apache#768] exclude the http dependency for hadoop common
41859c0
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 18, 2023
@beryllw
[apache#768] remove the blank lines
3890d23
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 18, 2023
@beryllw
[apache#768] change api path
f618afa
beryllw added a commit to beryllw/incubator-uniffle that referenced this issue Jun 18, 2023
@beryllw
[apache#768] Rename the variable.
cc665a5
jerqi pushed a commit that referenced this issue Jun 19, 2023
@beryllw
[#768] feat(cli): Cli method for blacklist update (#931)
f9369ab 
### What changes were proposed in this pull request?

 I created a command called uniffle cli to update blacklist, the following is the case of using the command.
```
Usage:
   Optional
     -a,--admin <arg>   This is an admin command that will print args.
     -c,--cli <arg>     This is an client cli command that will print args.
     -h,--help          Help for the Uniffle CLI.
     -rc,--refreshChecker    This is an admin command that will refresh access checker..
     -cc,--checkerClass <arg>     This is an client cli command that will print args.
     -s,--help <arg>          This is coordinator server host.
     -p,--port <arg>          This is coordinator server port.
```
> Run the example-cli command

uniffle admin-cli -rc -cc org.apache.uniffle.test.AccessClusterTest$MockedAccessChecker -s localhost -p 12345

### Why are the changes needed?

We use refreshChecker cli to update blacklist.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Unit test verification.
@jerqi
Copy link
Contributor

jerqi commented Jun 21, 2023

closed by #931

@jerqi jerqi closed this as completed Jun 21, 2023
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jun 25, 2023
[apache#768] [Follow Up] feat(cli): Cli method for blacklist update.
bdbe491
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jun 27, 2023
[apache#768] Fix CheckStyle.
0a99ccf
advancedxy pushed a commit that referenced this issue Jul 1, 2023
@slfan1989
[#768] [Follow Up] feat(cli): Cli method for blacklist update. (#968)
6dbb289 
### What changes were proposed in this pull request?

While reading the code, I found some minor issues, this PR will fix them.

- Issue1: When using the `uniffle admin-cli` command without any options, it should print the help information.

> before modification

<img width="575" alt="image" src="https://github.com/apache/incubator-uniffle/assets/55643692/8324e9fa-8bf7-4b8c-bbd4-76795fa8e105">

> after modification
<img width="660" alt="image" src="https://github.com/apache/incubator-uniffle/assets/55643692/8e3b53a8-faec-4d38-ae97-a420ba48c3fa">

- Issue2: The comment information is incorrect.

### Why are the changes needed?

Improve code readability and enhance code functionality.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Test environment verification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beryllw beryllw

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jerqi @beryllw @smallzhongfeng