[apache#768] add support ssl

beryllw · Jun 15, 2023 · 73e4168 · 73e4168
1 parent b8dcd4d
commit 73e4168
Showing 1 changed file with 16 additions and 4 deletions.
diff --git a/cli/src/main/java/org/apache/uniffle/cli/UniffleAdminCLI.java b/cli/src/main/java/org/apache/uniffle/cli/UniffleAdminCLI.java
@@ -33,10 +33,14 @@ public class UniffleAdminCLI extends AbstractCustomCommandLine {
   private static final Logger LOG = LoggerFactory.getLogger(UniffleAdminCLI.class);
 
   private final Options allOptions;
+
+  private final Option refreshAccessCli;
+
   private final Option checkerClass;
   private final Option coordinatorHost;
   private final Option coordPort;
-  private final Option refreshAccessCli;
+  private final Option ssl;
+
   private final Option help;
   protected UniffleRestClient client;
 
@@ -52,9 +56,12 @@ public UniffleAdminCLI(String shortPrefix, String longPrefix) {
         true, "This is coordinator server host.");
     coordPort = new Option(shortPrefix + "p", longPrefix + "port",
         true, "This is coordinator server port.");
+    ssl = new Option(null, longPrefix + "ssl", false, "use SSL");
+
+    allOptions.addOption(refreshAccessCli);
     allOptions.addOption(coordinatorHost);
     allOptions.addOption(coordPort);
-    allOptions.addOption(refreshAccessCli);
+    allOptions.addOption(ssl);
     allOptions.addOption(help);
   }
 
@@ -74,8 +81,13 @@ public int run(String[] args) throws UniffleCliArgsException {
     if (cmd.hasOption(coordinatorHost.getOpt()) && cmd.hasOption(coordPort.getOpt())) {
       String host = cmd.getOptionValue(coordinatorHost.getOpt()).trim();
       int port = Integer.parseInt(cmd.getOptionValue(coordPort.getOpt()).trim());
-      String hostUrl = String.format("https://%s:%d", host, port);
-      LOG.info("connected to coordinator: https://{}:{}.", host, port);
+      String hostUrl;
+      if (cmd.hasOption(ssl.getOpt())) {
+        hostUrl = String.format("https://%s:%d", host, port);
+      } else {
+        hostUrl = String.format("http://%s:%d", host, port);
+      }
+      LOG.info("connected to coordinator: {}.", hostUrl);
       client = UniffleRestClient.builder(hostUrl).build();
     }