Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support random grpc port #779

Closed
xumanbu opened this issue Mar 29, 2023 · 1 comment
Closed

Support random grpc port #779

xumanbu opened this issue Mar 29, 2023 · 1 comment
Assignees

Comments

@xumanbu
Copy link
Contributor

xumanbu commented Mar 29, 2023

Code of Conduct
I agree to follow this project's Code of Conduct

Search before asking
I have searched in the issues and found no similar issues.

Describe the subtask
For Grpc server, when we set the port to zero. we should bind a available random port.

Parent issue
#133

Are you willing to submit PR?
Yes I am willing to submit a PR!

@jerqi jerqi changed the title > Support random grpc port Support random grpc port Mar 29, 2023
xumanbu pushed a commit to xumanbu/incubator-uniffle that referenced this issue Apr 12, 2023
jerqi pushed a commit that referenced this issue Apr 13, 2023
### What changes were proposed in this pull request?
1. grpc server port support random port 
2. grpc sever will retry binding with increased port num if configured port is already occupied

### Why are the changes needed?
1. improve robustness for server startup
2. sync with netty server functionality

Fixs #779

### Does this PR introduce any user-facing change?
Yes. `rss.rpc.server.port` could be set as zero.

### How was this patch tested?
UT

Co-authored-by: jam.xu <jam.xu@vipshop.com>
@jerqi jerqi closed this as completed Apr 17, 2023
@jerqi
Copy link
Contributor

jerqi commented Apr 17, 2023

Closed by #820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants