[#779] feat: Grpc server support random port #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
changed the title
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
============================================
+ Coverage 57.63% 58.97% +1.33%
- Complexity 2058 2059 +1
============================================
Files 306 292 -14
Lines 14871 12909 -1962
Branches 1221 1224 +3
============================================
- Hits 8571 7613 -958
+ Misses 5808 4864 -944
+ Partials 492 432 -60
... and 19 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
approved these changes
Apr 12, 2023
zuston
reviewed
Apr 13, 2023
| this.port = conf.getInteger(RssBaseConf.RPC_SERVER_PORT); | ||
| long maxInboundMessageSize = conf.getLong(RssBaseConf.RPC_MESSAGE_MAX_SIZE); | ||
| this.rssConf = conf; | ||
| this.port = rssConf.getInteger(RssBaseConf.RPC_SERVER_PORT); |
There was a problem hiding this comment.
If using the random port, why reserve this var of port ? the listen port and port are unclear.
There was a problem hiding this comment.
agree with u.in same test case have reuse RssBaseConf(i think it is a mistake), retain
this the port var just reserve the configuration value to avoid test failed.
ShuffleWithRssClientTest
|
Sorry for the late review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fixs #779
Does this PR introduce any user-facing change?
Yes.
rss.rpc.server.portcould be set as zero.How was this patch tested?
UT