Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] define RPC_SERVER_TYPE as an enum #782

Closed
advancedxy opened this issue Mar 30, 2023 · 0 comments · Fixed by #783
Closed

[Improvement] define RPC_SERVER_TYPE as an enum #782

advancedxy opened this issue Mar 30, 2023 · 0 comments · Fixed by #783

Comments

@advancedxy
Copy link
Contributor

There are multiple definitions of ServerType enums, let's refactor that in a new pr.

Originally posted by @advancedxy in #777 (comment)
@advancedxy advancedxy changed the title define RPC_SERVER_TYPE as an enum [Improvement] define RPC_SERVER_TYPE as an enum Mar 30, 2023
@advancedxy advancedxy mentioned this issue Mar 30, 2023
Merged
@jerqi jerqi closed this as completed in #783 Apr 4, 2023
jerqi pushed a commit that referenced this issue Apr 4, 2023
@advancedxy
[#782]refactor: restrict rss.rpc.server.type to an enum (#783)
89f07fb 
### What changes were proposed in this pull request?
1. make RPC_SERVER_TYPE an enum
2. remove ServerType definition in various places

### Why are the changes needed?
This resolves #782

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Existing UTs
xianjingfeng pushed a commit to xianjingfeng/incubator-uniffle that referenced this issue Apr 5, 2023
@advancedxy
[apache#782]refactor: restrict rss.rpc.server.type to an enum (apache…
2a5792d 
…#783)

### What changes were proposed in this pull request?
1. make RPC_SERVER_TYPE an enum
2. remove ServerType definition in various places

### Why are the changes needed?
This resolves apache#782

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Existing UTs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#782]refactor: restrict rss.rpc.server.type to an enum advancedxy/incubator-uniffle
1 participant
@advancedxy