[#477][part-0] feat: add ShuffleManagerServer impl #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #777 +/- ##
============================================
- Coverage 61.16% 59.32% -1.84%
- Complexity 1985 2029 +44
============================================
Files 245 284 +39
Lines 13422 12554 -868
Branches 1125 1185 +60
============================================
- Hits 8209 7448 -761
+ Misses 4751 4693 -58
+ Partials 462 413 -49
... and 68 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
advancedxy
force-pushed
the
issue_477_part_0
branch
from
eb8d61f
to
67fb1c8
Compare
jerqi
reviewed
Mar 29, 2023
common/src/main/java/org/apache/uniffle/common/metrics/DummyGRPCMetrics.java
Outdated
Show resolved
Hide resolved
...st/spark-common/src/test/java/org/apache/uniffle/test/SimpleShuffleServerManagerE2ETest.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/apache/uniffle/client/response/RssReportShuffleFetchFailureResponse.java
Outdated
Show resolved
Hide resolved
jerqi
previously approved these changes
Mar 29, 2023
|
@zuston do you some any more comments? |
zuston
previously approved these changes
Mar 30, 2023
...spark/common/src/main/java/org/apache/uniffle/shuffle/manager/ShuffleManagerGrpcService.java
Show resolved
Hide resolved
...ark/common/src/main/java/org/apache/uniffle/shuffle/manager/ShuffleManagerServerFactory.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public GrpcServer getServer() { | ||
| String type = conf.getString(RssBaseConf.RPC_SERVER_TYPE); |
There was a problem hiding this comment.
It looks RPC_SERVER_TYPE should be refactored as ENUM type
There was a problem hiding this comment.
There are multiple definitions of ServerType enums, let's refactor that in a new pr.
...rnal-client/src/main/java/org/apache/uniffle/client/factory/ShuffleManagerClientFactory.java
Outdated
Show resolved
Hide resolved
| public class ShuffleManagerGrpcClient extends GrpcClient implements ShuffleManagerClient { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(ShuffleManagerGrpcClient.class); | ||
| private static final long RPC_TIMEOUT_DEFAULT_MS = 60000; |
There was a problem hiding this comment.
Should be. Let's do this in another pr. This code is aligned with other Client impls, such as ShuffleServerGrpcClient.
We should refactor these together.
zuston
approved these changes
Mar 30, 2023
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
### What changes were proposed in this pull request? 1. add shuffle manager proto 2. the corresponding client and server impls 3. add the RssShuffleManagerInterface ### Why are the changes needed? This is the first part of apache#477. To support re-submit spark stage, the ShuffleManagerServer should be introduced first. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added UTs and one integration test.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
This is the first part of #477.
To support re-submit spark stage, the ShuffleManagerServer should be introduced first.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added UTs and one integration test.