Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Support delete ShuffleServer pod with Evicted status #794

Closed
3 tasks done
xianjingfeng opened this issue Apr 4, 2023 · 0 comments · Fixed by #795
Closed
3 tasks done

[Improvement] Support delete ShuffleServer pod with Evicted status #794

xianjingfeng opened this issue Apr 4, 2023 · 0 comments · Fixed by #795

Comments

@xianjingfeng
Copy link
Member

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

When ShuffleServer pod is Evicted, we can't delete it.
If we try to delete it, the following logs will be printed

can not delete the shuffle server pod (xxxxxx) directly

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@xianjingfeng xianjingfeng mentioned this issue Apr 4, 2023
Merged
xianjingfeng added a commit that referenced this issue Apr 6, 2023
@xianjingfeng
[#794] feat(operator): support delete ShuffleServer pod with Evicted …
cb83c1c 
…status (#795)

### What changes were proposed in this pull request?
Support delete ShuffleServer pod with Evicted status

### Why are the changes needed?
When ShuffleServer pod is Evicted, we can't delete it.
Fix: #794

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
Manual testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@xianjingfeng