[#794] feat(operator): support delete ShuffleServer pod with Evicted status

[xianjingfeng]

What changes were proposed in this pull request?

Support delete ShuffleServer pod with Evicted status

Why are the changes needed?

When ShuffleServer pod is Evicted, we can't delete it.
Fix: #794

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manual testing

[codecov-commenter]

Codecov Report

Merging #795 (e185648) into master (567872b) will decrease coverage by 2.60%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master     #795      +/-   ##
============================================
- Coverage     60.67%   58.08%   -2.60%     
- Complexity     1901     2072     +171     
============================================
  Files           239      304      +65     
  Lines         13031    14816    +1785     
  Branches       1091     1212     +121     
============================================
+ Hits           7907     8606     +699     
- Misses         4686     5720    +1034     
- Partials        438      490      +52     

Impacted Files	Coverage Δ
...y/kubernetes/operator/pkg/webhook/inspector/pod.go	6.45% <66.66%> (+6.45%)	⬆️

... and 109 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[advancedxy]

cloud you add an ut for this change? The related ut should already been there

[xianjingfeng]

cloud you add an ut for this change? The related ut should already been there

I have tried but i found it is difficult. Because this operation involves updating the exclude-nodes and checking whether the shuffle server pod can be deleted. I think we need test it by integration test.

[advancedxy]

cloud you add an ut for this change? The related ut should already been there

I have tried but i found it is difficult. Because this operation involves updating the exclude-nodes and checking whether the shuffle server pod can be deleted. I think we need test it by integration test.

I believe you may extract the status check into a small method and add ut for that small method. You can check how rss_test.go is constructed.

[xianjingfeng]

cloud you add an ut for this change? The related ut should already been there

I have tried but i found it is difficult. Because this operation involves updating the exclude-nodes and checking whether the shuffle server pod can be deleted. I think we need test it by integration test.

I believe you may extract the status check into a small method and add ut for that small method. You can check how rss_test.go is constructed.

Updated

[advancedxy]

LGTM, exception one minor comment.
BTW, the ci is failed, you may have to look into it.