Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Exclude node files support comments for easy annotation of changes #863

Closed
3 tasks done
yl09099 opened this issue May 10, 2023 · 0 comments · Fixed by #874
Closed
3 tasks done

[Improvement] Exclude node files support comments for easy annotation of changes #863

yl09099 opened this issue May 10, 2023 · 0 comments · Fixed by #874
Assignees
@yl09099

Comments

@yl09099
Copy link
Contributor

yl09099 commented May 10, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

exclude node files support comments for easy annotation of changes

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
yl09099 pushed a commit to yl09099/incubator-uniffle that referenced this issue May 11, 2023
[apache#863] improvement(coordinator):Exclude node files support comm…
9f77098 
…ents for easy annotation of changes
yl09099 pushed a commit to yl09099/incubator-uniffle that referenced this issue May 11, 2023
@yl09099
[apache#863] improvement(coordinator):Exclude node files support comm…
02acf5d 
…ents for easy annotation of changes
@yl09099 yl09099 mentioned this issue May 11, 2023
Merged
yl09099 pushed a commit to yl09099/incubator-uniffle that referenced this issue May 11, 2023
@yl09099
[apache#863] improvement(coordinator):Exclude node files support comm…
ab2c2fc 
…ents for easy annotation of changes
kaijchen pushed a commit that referenced this issue May 11, 2023
@yl09099
[#863] feat(coordinator): support comments in exclude node files (#874)
9c26c1b 
### What changes were proposed in this pull request?

Support comments in exclude node files for easy annotation of changes.

### Why are the changes needed?

Fix: #863 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Updated UT: SimpleClusterManagerTest

Co-authored-by: markyuanlu <markyuanlu@didiglobal.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yl09099 yl09099

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#863] feat(coordinator): support comments in exclude node files yl09099/incubator-uniffle
1 participant
@yl09099