[#863] feat(coordinator): support comments in exclude node files #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallzhongfeng
changed the title
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
…ents for easy annotation of changes
smallzhongfeng
approved these changes
May 11, 2023
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
============================================
+ Coverage 56.58% 58.72% +2.13%
- Complexity 2175 2176 +1
============================================
Files 327 307 -20
Lines 15981 13621 -2360
Branches 1263 1263
============================================
- Hits 9043 7999 -1044
+ Misses 6430 5185 -1245
+ Partials 508 437 -71
... and 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
approved these changes
May 11, 2023
kaijchen
approved these changes
May 11, 2023
kaijchen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support comments in exclude node files for easy annotation of changes.
Why are the changes needed?
Fix: #863
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Updated UT: SimpleClusterManagerTest