Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][tez] convertTaskAttemptIdToLong should not consider appattemptid. #992

Closed
3 tasks done
zhengchenyu opened this issue Jul 4, 2023 · 0 comments · Fixed by #1007
Closed
3 tasks done

[Bug][tez] convertTaskAttemptIdToLong should not consider appattemptid. #992

zhengchenyu opened this issue Jul 4, 2023 · 0 comments · Fixed by #1007

Comments

@zhengchenyu
Copy link
Collaborator

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

When we convert task attempt id to long, consider real taskAttemptID = taskAttemptID - (appAttemptId - 1) * 1000, the logical only apply to mr. tez should remove this.

If appAttemptId is 2, taskattemptid will be normalized to negative value, it is unexpected.

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
zhengchenyu added a commit to zhengchenyu/incubator-uniffle that referenced this issue Jul 4, 2023
@zhengchenyu
[apache#992] bug(tez): convertTaskAttemptIdToLong should not consider…
26df48e 
… appattemptid.
zhengchenyu added a commit to zhengchenyu/incubator-uniffle that referenced this issue Jul 5, 2023
@zhengchenyu
[apache#992] bug(tez): convertTaskAttemptIdToLong should not consider…
df0ef06 
… appattemptid.
zhengchenyu added a commit to zhengchenyu/incubator-uniffle that referenced this issue Jul 5, 2023
@zhengchenyu
[apache#992] bug(tez): convertTaskAttemptIdToLong should not consider…
d7c1c91 
… appattemptid.
zhengchenyu added a commit to zhengchenyu/incubator-uniffle that referenced this issue Jul 12, 2023
@zhengchenyu
[apache#992] bug(tez): convertTaskAttemptIdToLong should not consider…
6187bd9 
… appattemptid.
zhengchenyu added a commit to zhengchenyu/incubator-uniffle that referenced this issue Jul 12, 2023
@zhengchenyu
[apache#992] bug(tez): convertTaskAttemptIdToLong should not consider…
5b48530 
… appattemptid.
@zhengchenyu zhengchenyu mentioned this issue Jul 12, 2023
Merged
zhengchenyu added a commit to zhengchenyu/incubator-uniffle that referenced this issue Jul 17, 2023
@zhengchenyu
[apache#992] fix(tez): convertTaskAttemptIdToLong should not consider…
3575e8d 
… appattemptId
jerqi pushed a commit that referenced this issue Jul 17, 2023
@zhengchenyu
[#992] fix(tez): convertTaskAttemptIdToLong should not consider appat…
16dedb9 
…temptId (#1007)

### What changes were proposed in this pull request?

When we convert task attempt id to long, consider real taskAttemptID = taskAttemptID - (appAttemptId - 1) * 1000, the logical only apply to mr. tez should remove this.

If appAttemptId is 2, taskattemptid will be normalized to negative value, it is unexpected.

Fix: #992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@zhengchenyu