Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#992] fix(tez): convertTaskAttemptIdToLong should not consider appattemptId #1007

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

zhengchenyu
Copy link
Collaborator

What changes were proposed in this pull request?

When we convert task attempt id to long, consider real taskAttemptID = taskAttemptID - (appAttemptId - 1) * 1000, the logical only apply to mr. tez should remove this.

If appAttemptId is 2, taskattemptid will be normalized to negative value, it is unexpected.

Fix: #992

@jerqi jerqi changed the title [#992] bug(tez): convertTaskAttemptIdToLong should not consider appat… [#992] fix(tez): convertTaskAttemptIdToLong should not consider appat… Jul 12, 2023
@jerqi jerqi changed the title [#992] fix(tez): convertTaskAttemptIdToLong should not consider appat… [#992] fix(tez): convertTaskAttemptIdToLong should not consider appatttemptId Jul 12, 2023
@jerqi jerqi changed the title [#992] fix(tez): convertTaskAttemptIdToLong should not consider appatttemptId [#992] fix(tez): convertTaskAttemptIdToLong should not consider appattemptId Jul 12, 2023
@zhengchenyu zhengchenyu deleted the 992 branch July 17, 2023 06:06
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zhengchenyu

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Merging #1007 (3575e8d) into master (411b445) will increase coverage by 1.16%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #1007      +/-   ##
============================================
+ Coverage     53.67%   54.83%   +1.16%     
  Complexity     2523     2523              
============================================
  Files           381      361      -20     
  Lines         21648    19284    -2364     
  Branches       1800     1799       -1     
============================================
- Hits          11620    10575    -1045     
+ Misses         9322     8078    -1244     
+ Partials        706      631      -75     
Impacted Files Coverage Δ
...c/main/java/org/apache/tez/common/RssTezUtils.java 63.13% <50.00%> (+0.57%) ⬆️
...ez/runtime/library/common/sort/impl/RssSorter.java 57.95% <100.00%> (-0.48%) ⬇️
.../runtime/library/common/sort/impl/RssUnSorter.java 63.63% <100.00%> (-0.41%) ⬇️

... and 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jerqi jerqi merged commit 16dedb9 into apache:master Jul 17, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][tez] convertTaskAttemptIdToLong should not consider appattemptid.
3 participants