Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1019] test(tez) RssOrderedPartitionedKVOutputTest add close func unit test #1025

Merged
merged 2 commits into from
Jul 20, 2023
Merged

[#1019] test(tez) RssOrderedPartitionedKVOutputTest add close func unit test #1025

merged 2 commits into from
Jul 20, 2023

Conversation

bin41215
Copy link
Contributor

@bin41215 bin41215 commented Jul 20, 2023

What changes were proposed in this pull request?

tez-client, RssOrderedPartitionedKVOutputTest add close func unit test

Why are the changes needed?

tez-client, RssOrderedPartitionedKVOutputTest add close func unit test

Fix: #1019

Does this PR introduce any user-facing change?

No.

How was this patch tested?

unit test.

@jerqi jerqi changed the title [#1019]improvement:tez-client,RssOrderedPartitionedKVOutputTest add c… [#1019] improvement(tez) RssOrderedPartitionedKVOutputTest add c… Jul 20, 2023
@jerqi jerqi changed the title [#1019] improvement(tez) RssOrderedPartitionedKVOutputTest add c… [#1019] improvement(tez) RssOrderedPartitionedKVOutputTest add lose func unit test Jul 20, 2023
@jerqi jerqi changed the title [#1019] improvement(tez) RssOrderedPartitionedKVOutputTest add lose func unit test [#1019] improvement(tez) RssOrderedPartitionedKVOutputTest add close func unit test Jul 20, 2023
@jerqi jerqi changed the title [#1019] improvement(tez) RssOrderedPartitionedKVOutputTest add close func unit test [#1019] test(tez) RssOrderedPartitionedKVOutputTest add close func unit test Jul 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #1025 (1830b5b) into master (d6b43f0) will increase coverage by 1.46%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1025      +/-   ##
============================================
+ Coverage     53.66%   55.12%   +1.46%     
- Complexity     2523     2530       +7     
============================================
  Files           382      362      -20     
  Lines         21672    19334    -2338     
  Branches       1795     1799       +4     
============================================
- Hits          11630    10658     -972     
+ Misses         9338     8041    -1297     
+ Partials        704      635      -69     

see 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bin41215

@jerqi jerqi merged commit 2e54ce2 into apache:master Jul 20, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] RssOrderedPartitionedKVOutputTest add close func unit test
3 participants