Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1019] test(tez) RssOrderedPartitionedKVOutputTest add close func unit test #1025

Merged
merged 2 commits into from
Jul 20, 2023
Merged

[#1019] test(tez) RssOrderedPartitionedKVOutputTest add close func unit test #1025

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6412f6f
[#1019]improvement:tez-client,RssOrderedPartitionedKVOutputTest add c…
bin41215 Jul 20, 2023
1830b5b
[#1019]improvement:tez-client,RssOrderedPartitionedKVOutputTest add c…
bin41215 Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions ...rc/test/java/org/apache/tez/runtime/library/output/RssOrderedPartitionedKVOutputTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,13 @@
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.io.Text;
import org.apache.hadoop.ipc.RPC;
import org.apache.hadoop.yarn.api.records.ContainerId;
import org.apache.hadoop.yarn.util.ConverterUtils;
import org.apache.tez.common.GetShuffleServerResponse;
import org.apache.tez.common.ShuffleAssignmentsInfoWritable;
import org.apache.tez.common.TezCommonUtils;
import org.apache.tez.common.TezRemoteShuffleUmbilicalProtocol;
import org.apache.tez.common.TezRuntimeFrameworkConfigs;
import org.apache.tez.common.TezUtilsInternal;
import org.apache.tez.runtime.api.Event;
Expand All @@ -41,21 +47,35 @@
import org.apache.tez.runtime.library.partitioner.HashPartitioner;
import org.apache.tez.runtime.library.shuffle.impl.ShuffleUserPayloads;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.Timeout;
import org.mockito.MockedStatic;
import org.mockito.Mockito;

import org.apache.uniffle.common.ShuffleAssignmentsInfo;
import org.apache.uniffle.common.ShuffleServerInfo;

import static org.apache.tez.common.RssTezConfig.RSS_AM_SHUFFLE_MANAGER_ADDRESS;
import static org.apache.tez.common.RssTezConfig.RSS_AM_SHUFFLE_MANAGER_PORT;
import static org.apache.tez.common.RssTezConfig.RSS_SHUFFLE_DESTINATION_VERTEX_ID;
import static org.apache.tez.common.RssTezConfig.RSS_SHUFFLE_SOURCE_VERTEX_ID;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyLong;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock;

public class RssOrderedPartitionedKVOutputTest {
private static Map<Integer, List<ShuffleServerInfo>> partitionToServers = new HashMap<>();
private Configuration conf;
private FileSystem localFs;
private Path workingDir;

/** set up */
@BeforeEach
public void setup() throws IOException {
conf = new Configuration();
Expand All @@ -70,6 +90,10 @@ public void setup() throws IOException {
conf.set(
TezRuntimeConfiguration.TEZ_RUNTIME_PARTITIONER_CLASS, HashPartitioner.class.getName());
conf.setStrings(TezRuntimeFrameworkConfigs.LOCAL_DIRS, workingDir.toString());
conf.set(RSS_AM_SHUFFLE_MANAGER_ADDRESS, "localhost");
conf.setInt(RSS_AM_SHUFFLE_MANAGER_PORT, 0);
conf.setInt(RSS_SHUFFLE_SOURCE_VERTEX_ID, 0);
conf.setInt(RSS_SHUFFLE_DESTINATION_VERTEX_ID, 1);
}

@AfterEach
Expand Down Expand Up @@ -103,4 +127,34 @@ public void testNonStartedOutput() throws Exception {
assertTrue(emptyPartionsBitSet.get(i));
}
}

@Test
@Timeout(value = 8000, unit = TimeUnit.MILLISECONDS)
public void testClose() throws Exception {
try (MockedStatic<RPC> rpc = Mockito.mockStatic(RPC.class); ) {
TezRemoteShuffleUmbilicalProtocol protocol = mock(TezRemoteShuffleUmbilicalProtocol.class);
GetShuffleServerResponse response = new GetShuffleServerResponse();
ShuffleAssignmentsInfo shuffleAssignmentsInfo =
new ShuffleAssignmentsInfo(new HashMap(), new HashMap());
response.setShuffleAssignmentsInfoWritable(
new ShuffleAssignmentsInfoWritable(shuffleAssignmentsInfo));
doReturn(response).when(protocol).getShuffleAssignments(any());
rpc.when(() -> RPC.getProxy(any(), anyLong(), any(), any())).thenReturn(protocol);
try (MockedStatic<ConverterUtils> converterUtils = Mockito.mockStatic(ConverterUtils.class)) {
ContainerId containerId = ContainerId.newContainerId(OutputTestHelpers.APP_ATTEMPT_ID, 1);
converterUtils.when(() -> ConverterUtils.toContainerId(null)).thenReturn(containerId);
converterUtils
.when(() -> ConverterUtils.toContainerId(anyString()))
.thenReturn(containerId);
OutputContext outputContext = OutputTestHelpers.createOutputContext(conf, workingDir);
int numPartitions = 1;
RssOrderedPartitionedKVOutput output =
new RssOrderedPartitionedKVOutput(outputContext, numPartitions);
output.initialize();
output.start();
Assertions.assertNotNull(output.getWriter());
output.close();
}
}
}
}