Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1018] test(tez) RssUnorderedPartitionedKVOutputTest add close func ut #1034

Merged
merged 1 commit into from
Jul 24, 2023
Merged

[#1018] test(tez) RssUnorderedPartitionedKVOutputTest add close func ut #1034

merged 1 commit into from
Jul 24, 2023

Conversation

bin41215
Copy link
Contributor

What changes were proposed in this pull request?

tez-client, RssUnorderedPartitionedKVOutputTest add close func unit test

Why are the changes needed?

tez-client, RssUnorderedPartitionedKVOutputTest add close func unit test

Fix: #1018

Does this PR introduce any user-facing change?

No.

How was this patch tested?

unit test.

@jerqi jerqi changed the title test(tez) RssUnorderedPartitionedKVOutputTest add close func … [#1018] test(tez) RssUnorderedPartitionedKVOutputTest add close func ut Jul 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #1034 (ecb1162) into master (ecfed5e) will increase coverage by 1.52%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1034      +/-   ##
============================================
+ Coverage     54.10%   55.62%   +1.52%     
- Complexity     2547     2552       +5     
============================================
  Files           382      362      -20     
  Lines         21728    19368    -2360     
  Branches       1802     1802              
============================================
- Hits          11755    10773     -982     
+ Misses         9269     7961    -1308     
+ Partials        704      634      -70     

see 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , thanks @bin41215 , merged.

@jerqi jerqi merged commit 6fb2a9a into apache:master Jul 24, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] RssUnorderedPartitionedKVOutputTest add close func unit test
3 participants