[#640] feat(netty): Metric system for netty server #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
changed the title
|
@leixm Could you help me review this pr? |
Sure. |
leixm
requested changes
Jul 27, 2023
| } | ||
|
|
||
| public void incRequest(String className) { | ||
| if (isRegistered) { |
There was a problem hiding this comment.
Could we reuse RPCMetrics#incCounter? seems same code logic.
| } | ||
|
|
||
| public void decRequest(String className) { | ||
| if (isRegistered) { |
|
+1 LGTM. |
leixm
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add NettyMetrics for StreamSever
Why are the changes needed?
Fix: #640
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT