[#640] feat(netty): Metric system for netty server #1041
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.uniffle.common.metrics; | ||
|
|
||
| import io.prometheus.client.Counter; | ||
| import io.prometheus.client.Gauge; | ||
|
|
||
| public abstract class NettyMetrics extends RPCMetrics { | ||
|
|
||
| private static final String NETTY_ACTIVE_CONNECTION = "netty_active_connection"; | ||
| private static final String NETTY_HANDLE_EXCEPTION = "netty_handle_exception"; | ||
|
|
||
| protected Gauge.Child gaugeNettyActiveConn; | ||
| protected Counter.Child counterNettyException; | ||
|
|
||
| public NettyMetrics(String tags) { | ||
| super(tags); | ||
| } | ||
|
|
||
| @Override | ||
| public void registerGeneralMetrics() { | ||
| gaugeNettyActiveConn = metricsManager.addLabeledGauge(NETTY_ACTIVE_CONNECTION); | ||
| counterNettyException = metricsManager.addLabeledCounter(NETTY_HANDLE_EXCEPTION); | ||
| } | ||
|
|
||
| public void incRequest(String className) { | ||
| if (isRegistered) { | ||
| Gauge.Child gauge = gaugeMap.get(className); | ||
| if (gauge != null) { | ||
| gauge.inc(); | ||
| } | ||
| Counter.Child counter = counterMap.get(className); | ||
| if (counter != null) { | ||
| counter.inc(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public void decRequest(String className) { | ||
| if (isRegistered) { | ||
|
|
||
| Gauge.Child gauge = gaugeMap.get(className); | ||
| if (gauge != null) { | ||
| gauge.dec(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public Counter.Child getCounterNettyException() { | ||
| return counterNettyException; | ||
| } | ||
|
|
||
| public Gauge.Child getGaugeNettyActiveConn() { | ||
| return gaugeNettyActiveConn; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,149 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.uniffle.common.metrics; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| import com.google.common.collect.Maps; | ||
| import io.prometheus.client.CollectorRegistry; | ||
| import io.prometheus.client.Counter; | ||
| import io.prometheus.client.Gauge; | ||
| import io.prometheus.client.Summary; | ||
|
|
||
| import org.apache.uniffle.common.util.Constants; | ||
| import org.apache.uniffle.common.util.JavaUtils; | ||
|
|
||
| public abstract class RPCMetrics { | ||
| protected boolean isRegistered = false; | ||
| protected Map<String, Counter.Child> counterMap = JavaUtils.newConcurrentMap(); | ||
| protected Map<String, Gauge.Child> gaugeMap = JavaUtils.newConcurrentMap(); | ||
| protected Map<String, Summary.Child> transportTimeSummaryMap = JavaUtils.newConcurrentMap(); | ||
| protected Map<String, Summary.Child> processTimeSummaryMap = JavaUtils.newConcurrentMap(); | ||
| protected MetricsManager metricsManager; | ||
| protected String tags; | ||
|
|
||
| public RPCMetrics(String tags) { | ||
| this.tags = tags; | ||
| } | ||
|
|
||
| public abstract void registerMetrics(); | ||
|
|
||
| public abstract void registerGeneralMetrics(); | ||
|
|
||
| public void register(CollectorRegistry collectorRegistry) { | ||
| if (!isRegistered) { | ||
| Map<String, String> labels = Maps.newHashMap(); | ||
| labels.put(Constants.METRICS_TAG_LABEL_NAME, tags); | ||
| metricsManager = new MetricsManager(collectorRegistry, labels); | ||
| registerGeneralMetrics(); | ||
| registerMetrics(); | ||
| isRegistered = true; | ||
| } | ||
| } | ||
|
|
||
| public void setGauge(String tag, double value) { | ||
| if (isRegistered) { | ||
| Gauge.Child gauge = gaugeMap.get(tag); | ||
| if (gauge != null) { | ||
| gauge.set(value); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public void incGauge(String tag) { | ||
| incGauge(tag, 1); | ||
| } | ||
|
|
||
| public void incGauge(String tag, double value) { | ||
| if (isRegistered) { | ||
| Gauge.Child gauge = gaugeMap.get(tag); | ||
| if (gauge != null) { | ||
| gauge.inc(value); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public void decGauge(String tag) { | ||
| decGauge(tag, 1); | ||
| } | ||
|
|
||
| public void decGauge(String tag, double value) { | ||
| if (isRegistered) { | ||
| Gauge.Child gauge = gaugeMap.get(tag); | ||
| if (gauge != null) { | ||
| gauge.dec(value); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public void incCounter(String methodName) { | ||
| if (isRegistered) { | ||
| Gauge.Child gauge = gaugeMap.get(methodName); | ||
| if (gauge != null) { | ||
| gauge.inc(); | ||
| } | ||
| Counter.Child counter = counterMap.get(methodName); | ||
| if (counter != null) { | ||
| counter.inc(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public void decCounter(String methodName) { | ||
| if (isRegistered) { | ||
| Gauge.Child gauge = gaugeMap.get(methodName); | ||
| if (gauge != null) { | ||
| gauge.dec(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public void recordTransportTime(String methodName, long transportTimeInMillionSecond) { | ||
| Summary.Child summary = transportTimeSummaryMap.get(methodName); | ||
| if (summary != null) { | ||
| summary.observe(transportTimeInMillionSecond / Constants.MILLION_SECONDS_PER_SECOND); | ||
| } | ||
| } | ||
|
|
||
| public void recordProcessTime(String methodName, long processTimeInMillionSecond) { | ||
| Summary.Child summary = processTimeSummaryMap.get(methodName); | ||
| if (summary != null) { | ||
| summary.observe(processTimeInMillionSecond / Constants.MILLION_SECONDS_PER_SECOND); | ||
| } | ||
| } | ||
|
|
||
| public CollectorRegistry getCollectorRegistry() { | ||
| return metricsManager.getCollectorRegistry(); | ||
| } | ||
|
|
||
| public Map<String, Counter.Child> getCounterMap() { | ||
| return counterMap; | ||
| } | ||
|
|
||
| public Map<String, Gauge.Child> getGaugeMap() { | ||
| return gaugeMap; | ||
| } | ||
|
|
||
| public Map<String, Summary.Child> getTransportTimeSummaryMap() { | ||
| return transportTimeSummaryMap; | ||
| } | ||
|
|
||
| public Map<String, Summary.Child> getProcessTimeSummaryMap() { | ||
| return processTimeSummaryMap; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we reuse RPCMetrics#incCounter? seems same code logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good advice.