Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1048] fix(coord): ExcludeNodes does not take effect when the coordinator restarts. #1049

Merged
merged 9 commits into from
Jul 28, 2023

Conversation

leixm
Copy link
Contributor

@leixm leixm commented Jul 28, 2023

What changes were proposed in this pull request?

Make updateExcludeNodes no delay first time.

Why are the changes needed?

Fix: #1048.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT.

@jerqi jerqi changed the title [#1048] [Bug] ExcludeNodes does not take effect when the coordinator restarts. [#1048] fix(coord): ExcludeNodes does not take effect when the coordinator restarts. Jul 28, 2023
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @leixm , wait for CI.

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Merging #1049 (ad5a1d0) into master (a5ba479) will increase coverage by 1.18%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1049      +/-   ##
============================================
+ Coverage     54.28%   55.47%   +1.18%     
- Complexity     2549     2550       +1     
============================================
  Files           386      366      -20     
  Lines         21828    19468    -2360     
  Branches       1807     1807              
============================================
- Hits          11849    10799    -1050     
+ Misses         9277     8040    -1237     
+ Partials        702      629      -73     
Files Changed Coverage Δ
...ache/uniffle/coordinator/SimpleClusterManager.java 77.52% <ø> (+0.56%) ⬆️

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jerqi jerqi merged commit 57c35ad into apache:master Jul 28, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ExcludeNodes does not take effect when the coordinator restarts.
3 participants